-----Original Message-----
From: Ben Hutchings <ben.hutchings@...>
Sent: Wednesday, June 19, 2019 12:07 AM
To: sangorrin daniel(サンゴリン ダニエル ○ＳＷＣ□ＯＳＴ) <daniel.sangorrin@...>
Cc: cip-dev@...
Subject: Re: [cip-kernel-sec 1/3] remotes: check that remotes exist

-----Original Message-----
From: Ben Hutchings <ben.hutchings@...>
Sent: Wednesday, June 19, 2019 12:07 AM
To: sangorrin daniel(サンゴリン ダニエル ○ＳＷＣ□ＯＳＴ) <daniel.sangorrin@...>
Cc: cip-dev@...
Subject: Re: [cip-kernel-sec 1/3] remotes: check that remotes exist

This mostly looks fine, except:

On Tue, 2019-06-18 at 11:40 +0900, Daniel Sangorrin wrote:
[...]

--- /dev/null
+++ b/scripts/prepare_remotes.py

[...]

+def main(git_repo, remotes, debug=False):
+    kernel_sec.branch.check_git_repo(git_repo, remotes, create=True)

The debug flag doesn't have any effect...

[...]

+    parser.add_argument('--debug',
+                        dest='debug', action='store_true',
+                        help='enable debugging output')

[...]

...so neither does the --debug option.

I think you can remove them both.

Ben.

--
Ben Hutchings, Software Developer   Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom