Re: [PATCH 4.19.y-cip 08/12] phy: renesas: rcar-gen3-usb2: follow the hardware manual procedure
Pavel Machek
Hi!
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...> @@ -310,16 +310,21 @@ static void rcar_gen3_init_otg(struct rcar_gen3_chan *ch)I don't understand the comment here. Actually having function to set/clear bits in arbitrary register might be a nice cleanup. While reviewing that I noticed: static void rcar_gen3_init_otg(struct rcar_gen3_chan *ch) ... val = readl(usb2_base + USB2_LINECTRL1); rcar_gen3_set_linectrl(ch, 0, 0); writel(val | USB2_LINECTRL1_DPRPD_EN | USB2_LINECTRL1_DMRPD_EN, usb2_base + USB2_LINECTRL1); AFAICT it modifies the register only to undo those chanes immediately. Is it intentional? Is it worth a comment? Can the block be replaced with static void rcar_gen3_init_otg(struct rcar_gen3_chan *ch) ... rcar_gen3_set_linectrl(ch, 0, 0); rcar_gen3_set_linectrl(ch, 1, 1); ? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|
|