On Wed, 2019-07-17 at 07:47 +0000, Biju Das wrote:
Thanks for the feedback.
-----Original Message-----Please see the document  and  section 8, that have the details related to wrap around.
From: Pavel Machek <pavel@...>
Sent: Tuesday, July 16, 2019 10:04 PM
To: Biju Das <biju.das@...>
Subject: Re: [cip-dev] [PATCH 4.4.y-cip 03/10] rtc: pcf85363: set time
On Tue 2019-07-16 09:15:14, Biju Das wrote:
commit 188306ac9536ec47674ffa9dd330f69927679aeb upstream.How does wrap around work? AFAICT it is supposed to have ram at 0x40.
As per 8.2.6 Setting and reading the time in RTC mode, first stop the
clok, then reset it before setting the date and time registers.
Finally, start the clock.
This uses register address wrap around from 0x2f to 0x00 for
Regardless of what the hardware does...
Does it really provide increased efficiency (given regmap layer in
between) and will such trick cause problems in future? If regmap is not
aware of register mirrors it might get confused and provide stale values, for
...I think Pavel is right on this point. regmap doesn't seem to have
any provision for register addresses wrapping around, and it looks like
this causes a buffer overrun in the register cache.
Ben Hutchings, Software Developer Codethink Ltdhttps://www.codethink.co.uk/
Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom