Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro


Biju Das <biju.das@...>
 

+ Morimoto-San,

Subject: Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro

Hi!

--- a/include/sound/soc-dpcm.h
+++ b/include/sound/soc-dpcm.h
@@ -103,6 +103,9 @@ struct snd_soc_dpcm_runtime {
int trigger_pending; /* trigger cmd + 1 if pending, 0 if not */ };

+#define for_each_dpcm_fe(be, stream, dpcm)
\
+ list_for_each_entry(dpcm, &(be)->dpcm[stream].fe_clients, list_fe)
+
This macro is really confusing. dpcm is used as both control variable of the
loop and name of the field in *be. Plus it relies on list_fe variable to be
present in the context including it... that's non-standard.

Oh and "&(be)->" can be written as "(be)." AFAICT.
Morimoto-San,
Do you have any opinion on Pavel's findings?

Regards,
Biju

Join {cip-dev@lists.cip-project.org to automatically receive all group messages.