Re: [PATCH 4.19.y-cip 19/57] ASoC: rsnd: use 32bit TDM width as default


Kuninori Morimoto <kuninori.morimoto.gx@...>
 

Hi

@@ -738,8 +738,8 @@ static int rsnd_soc_set_dai_tdm_slot(struct snd_soc_dai *dai,
case 32:
break;
default:
- dev_err(dev, "unsupported slot width value: %d\n", slot_width);
- return -EINVAL;
+ /* use default */
+ slot_width = 32;
}

switch (slots) {
I don't think I like this. People should not be passing strange values to this
function. Can the caller be fixed, instead?
Morimoto San, Do you agree to Pavel's comment?
As git-log said, it is default values, not strange value.
People don't set all settings, especially it was default.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

Join cip-dev@lists.cip-project.org to automatically receive all group messages.