Re: [PATCH 4.19.y-cip 19/57] ASoC: rsnd: use 32bit TDM width as default

Pavel Machek

On Wed 2019-10-23 10:45:18, Kuninori Morimoto wrote:


@@ -738,8 +738,8 @@ static int rsnd_soc_set_dai_tdm_slot(struct snd_soc_dai *dai,
case 32:
- dev_err(dev, "unsupported slot width value: %d\n", slot_width);
- return -EINVAL;
+ /* use default */
+ slot_width = 32;

switch (slots) {
I don't think I like this. People should not be passing strange values to this
function. Can the caller be fixed, instead?
Morimoto San, Do you agree to Pavel's comment?
As git-log said, it is default values, not strange value.
People don't set all settings, especially it was default.
I'd understand turning 0 to 32 (that is if someone forgot to set
it?). But turning 19 into 32 seems wrong.

Best regards,
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join to automatically receive all group messages.