Re: [PATCH 4.19.y-cip 17/23] usb: typec: add dependency for TYPEC_HD3SS3220

Pavel Machek


On Tue 2020-02-18 14:05:14, Marian-Cristian Rotariu wrote:
From: Mao Wenan <>

commit da4b5d18dd949abdda7c8ea76c9483b5edd49616 upstream.

can be found:
drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove':
hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put'
drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set':
hd3ss3220.c:(.text+0x154): undefined reference to
drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role':
hd3ss3220.c:(.text+0x294): undefined reference to
hd3ss3220.c:(.text+0x2f4): undefined reference to
hd3ss3220.c:(.text+0x348): undefined reference to
hd3ss3220.c:(.text+0x390): undefined reference to
drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe':
hd3ss3220.c:(.text+0x5e8): undefined reference to
hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put'
make: *** [vmlinux] Error 1
I guess it is okay here, but for more serious bugs it would be nice to merge
the buggy patch with a fix -- not to break bisect.
I kind of forgot about bisect. I was mostly focused on keeping the original patches
from upstream (in this case, it is more about the commit message as the fix is trivial).
I will send this patch in v2 also, since you mostly agreed with it. Please let me know
if otherwise.
This patch is okay.

Best regards,

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join to automatically receive all group messages.