Re: [PATCH 4.4.y-cip 0/3] ARM: dts: am335x: Replace numeric pinmux address with macro defines

Pavel Machek


Tony Lindgren (1):
ARM: dts: am33xx: Added AM33XX_PADCONF macro

arch/arm/boot/dts/am335x-moxa-uc-8100-me-t.dts | 116 +++++++++++-----------
include/dt-bindings/pinctrl/am33xx.h | 130 ++++++++++++++++++++++++-
include/dt-bindings/pinctrl/omap.h | 1 +
3 files changed, 188 insertions(+), 59 deletions(-)
These should be the following:

Christina Quast (3):
ARM: dts: am33xx: Added macros for numeric pinmux addresses
ARM: dts: am33xx: Added AM33XX_PADCONF macro
ARM: dts: am335x: moxa-uc-8100-me-t: Replaced register offsets with
There's nothing obviously wrong with the patches (and they won't break
anything but am335x-moxa platform, so they are low risk).

On the other hand, I don't see any obvious benefit. Whether we use hex
constants or symbolic constants affects readability, but has no effect
on functionality.

Do you have any patches on top of these that rely on symbolic
constants in the dts? Are there any changes in the generated .dtb?
What is the benefit of this series (besides cleanup)?

Best regards,
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join to automatically receive all group messages.