-----Original Message-----
From: Pavel Machek <pavel@...>
Sent: 17 July 2020 09:25
To: cip-dev@...
Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...>; Pavel
Machek <pavel@...>; Chris Paterson <Chris.Paterson2@...>;
Biju Das <biju.das.jz@...>; Prabhakar Mahadev Lad
<prabhakar.mahadev-lad.rj@...>
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] serial: sh-sci: Make sure status
register SCxSR is read in correct sequence

Hi!

From: Kazuhiro Fujita <kazuhiro.fujita.jg@...>

commit 3dc4db3662366306e54ddcbda4804acb1258e4ba upstream.

For SCIF and HSCIF interfaces the SCxSR register holds the status of
data that is to be read next from SCxRDR register, But where as for
SCIFA and SCIFB interfaces SCxSR register holds status of data that is
previously read from SCxRDR register.

This patch makes sure the status register is read depending on the
port types so that errors are caught accordingly.

Looks good to me.

Cc: <stable@...>

I notice this applies cleanly to v4.4-stable. Was this submitted to
4.4 / do you need some help there?

The original patch is not cleanly applied on 4.4 see the mail below

https://www.spinics.net/lists/linux-renesas-soc/msg48219.html

Does this have user-visible impact?

No, You can verify this on console after applying the patch.

stty evenp

Test Case 1:

paste "p" on the console should generate parity error and "o" should not

Test Case 2:-

paste "ppppp" on the console should generate parity error and "ooooo" should not

Testcase 3:-

Paste "pop", it should generate parity error for "p"

Regards,
Biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647