Re: [PATCH 1/3] cip-security: Add packages for IEC-62443-4-2 Evaluation.


Daniel Sangorrin <daniel.sangorrin@...>
 

Hi Jan,

From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Jan Kiszka
Sent: Thursday, July 23, 2020 10:53 PM
Don't worry. The submission looked fairly good otherwise, not like first-time!

BTW, I'm still ambivalent whether to do UI (MRs) or cip-dev based patch reviews for isar-cip-core. As contributions increase, you
contributors need to express your preference. I'm used to both by now, I have troubles with both by now. However, we just need to
consolidate over one system because we can't couple them reasonably.
Patches give you greater visibility (all cip-dev members), but I can see some benefits in using MRs as well:
* merge when the pipeline succeeds
* map issues with the patches that close them
* discussions are kept close to the code
* no need for guru e-mail clients that don't mesh with your TABs Lol.
* they are more user friendly (push the merge request button instead of having to configure git send-email which can be problematic in corporate environments)

I am open to use any of them.

Thanks,
Daniel

Join cip-dev@lists.cip-project.org to automatically receive all group messages.