Re: [linux-cip:linux-4.19.y-cip 7/17] drivers/gpu/drm/drm_atomic.c:1264:1: warning: no previous prototype for 'drm_atomic_get_old_private_obj_state'

Pavel Machek


I have received a warning message mail from Kernel test robot. I have investigated this issue and found there were lots of warnings with architecture by following the steps mentioned in this mail.

Then I investigated this particular issue and found that issue is caused by bad commit done by me while backporting. The below backport commit has
extra functions from patch1(0001-drm-Add-drm_atomic_get_old-new_private_obj_state.patch), but the corresponding header is missing.

cip commit: cacc2a81b9872aa8830353110b1252021f124ae8
upstream commit: 1b27fbdde1df172dba604855c45078d741f8c858

I have attached 3 patches, that looks like fixes the issue mentioned by kernel robot.

How do we proceed here?
drop cip commit: cacc2a81b9872aa8830353110b1252021f124ae8 and apply the 3 patches to fix this issue?
First I want to make sure: we are talking about commit
60b4667275b60d92c760d48df95f5b80bbcfde6e? Because I don't see
cacc2a81b9872aa8830353110b1252021f124ae8 around.

Best regards,

commit 60b4667275b60d92c760d48df95f5b80bbcfde6e
Author: Laurent Pinchart <laurent.pinchart@...>
Date: Wed Jul 22 17:34:39 2020 +0100

drm: Add drm_atomic_get_(old|new)_connector_for_encoder() helpers

commit 1b27fbdde1df172dba604855c45078d741f8c858 upstream.

Add functions to the atomic core to retrieve the old and new
connectors associated with an encoder in a drm_atomic_state. This
is useful for encoders and bridges that need to access the
connector, for instance for the drm_display_info.

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join to automatically receive all group messages.