Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set

Biju Das <biju.das.jz@...>

Hi Pavel,

Thanks for the feedback.

Subject: Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set


I assume this patch is for 4.19-cip?
Yes, it is for 4.19-cip.

commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.

The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
the stub is declared in drm_of.h without a static inline. This causes
multiple definitions of the function to be linked when the CONFIG_OF
option isn't set. Fix it by making the stub static inline.
So this is pretty obvious, and I'll likely apply it.
Thanks for applying it.


Best regards,

diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index
8ec7ca6d2369..b9b093add92e 100644
--- a/include/drm/drm_of.h
+++ b/include/drm/drm_of.h
@@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const
struct device_node *np,
return -EINVAL;

-int drm_of_lvds_get_dual_link_pixel_order(const struct device_node
- const struct device_node *port2)
+static inline int
+drm_of_lvds_get_dual_link_pixel_order(const struct device_node
+ const struct device_node *port2)
return -EINVAL;
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Join to automatically receive all group messages.