Re: [linux-cip:linux-4.19.y-cip 7/17] drivers/gpu/drm/drm_atomic.c:1264:1: warning: no previous prototype for 'drm_atomic_get_old_private_obj_state'


Biju Das <biju.das.jz@...>
 

Hi Pavel,

Thanks for the feedback.

drivers/gpu/drm/drm_atomic.c:1264:1: warning: no previous prototype for
'drm_atomic_get_old_private_obj_state'

Hi!

I have received a warning message mail from Kernel test robot. I have
investigated this issue and found there were lots of warnings with
architecture by following the steps mentioned in this mail.

Then I investigated this particular issue and found that issue is
caused by bad commit done by me while backporting. The below backport
commit has extra functions from patch1(0001-drm-Add-
drm_atomic_get_old-new_private_obj_state.patch), but the corresponding
header is missing.

cip commit: cacc2a81b9872aa8830353110b1252021f124ae8
upstream commit: 1b27fbdde1df172dba604855c45078d741f8c858

I have attached 3 patches, that looks like fixes the issue mentioned by
kernel robot.

How do we proceed here?
drop cip commit: cacc2a81b9872aa8830353110b1252021f124ae8 and apply
the 3 patches to fix this issue?
First I want to make sure: we are talking about commit
60b4667275b60d92c760d48df95f5b80bbcfde6e? Because I don't see
cacc2a81b9872aa8830353110b1252021f124ae8 around.
Yes, I am talking about 60b4667275b60d92c760d48df95f5b80bbcfde6e.

Cheers,
Biju



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Join cip-dev@lists.cip-project.org to automatically receive all group messages.