Re: [PATCH 4.4.y-cip] of: Add missing exports of node name compare functions


Pavel Machek
 

Hi!

Commit f42b0e18f2e5 ("of: add node name compare helper functions")
failed to add the module exports to of_node_name_eq() and
of_node_name_prefix(). Add them now.

Fixes: f42b0e18f2e5 ("of: add node name compare helper functions")
Signed-off-by: Rob Herring <robh@...>
Signed-off-by: Lad Prabhakar
<prabhakar.mahadev-lad.rj@...>
---
Fixes build failure for multi_v7_defconfig
---
Ok, what is going on here?

I don't believe f42b0e18f2e5 causes build failure; it adds functions,
but it can't cause build failure without a user.

Which commit fails the build? Do we have that in 4.4.y-cip? Can
this be placed before the buggy commit so that build is not broken?
For multi_v7_defconfig I get this below build error:

ERROR: "of_node_name_eq" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1161: recipe for target 'modules' failed
make: *** [modules] Error 2

commit eeaa48eee492d ("drm: rcar-du: Support panels connected directly to the DPAD outputs") fails the build which was added in 4.4-cip kernel.
Aha, so I'd expect Fixes: eeaa48eee492d ("drm: rcar-du: Support panels
connected directly to the DPAD outputs") in this patch. And yes, this
means that failure is real and this patch should go in.

ACK.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join cip-dev@lists.cip-project.org to automatically receive all group messages.