[PATCH 4.4.y-cip 08/11] cpufreq: ti-cpufreq: Fix an incorrect error return value

Chen-Yu Tsai (Moxa) <wens@...>

From: Suman Anna <s-anna@...>

commit e5d295b06d69a1924665a16a4987be475addd00f upstream.

Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when
failure") has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.

Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")
Cc: 4.14+ <stable@...> # v4.14+
Signed-off-by: Suman Anna <s-anna@...>
Acked-by: Viresh Kumar <viresh.kumar@...>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...>
[wens@...: Fix commit reference format in commit log]
Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...>
drivers/cpufreq/ti-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index afbe9db29992d..59777685114d9 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -218,7 +218,7 @@ static int ti_cpufreq_init(void)
opp_data->cpu_dev =3D get_cpu_device(0);
if (!opp_data->cpu_dev) {
pr_err("%s: Failed to get device for CPU0\n", __func__);
- ret =3D ENODEV;
+ ret =3D -ENODEV;
goto free_opp_data;

Join cip-dev@lists.cip-project.org to automatically receive all group messages.