Re: If you are using PCIe EP, speak up was Re: [RFC PATCH 4.19.y-cip 00/50] Add PCIe EP support for Renesas R-Car Gen3 and RZ/G2x
Lad Prabhakar
Hi Pavel,
toggle quoted messageShow quoted text
-----Original Message-----Thank you for the review. That’s a relief 😊 Fingers crossed.* Since the changes are huge I am sending the patches as RFC.And yes, it is quite big, which might be a problem. OTOH only Renesas [If someone else _is_ using it or is considering using it, pleaseSure this was cherry picked from upstream I haven’t modified the description. Moreover this I had include because the subsequent patches could apply cleanly. Do want me to just elaborate the commit message you mean ? Should 30/ and 31/ be submitted to stable?Yes I do agree. Sure Ill wait for them, (fyi these are just dt binding documentation and PCI-ID addition patches)* Required EP framework changes and fixes are ported as well.Ok, so we definitely want them in upstream, not in -next. And it might Sure.* I was skeptic with patch 36/50 "Rename pcie-rcar.c to pcie-rcar-host.c"Let me take a look at these in bigger detail. You mean the R-Car Gen3 PCIe EP driver ?* As the changes touches three other controller drivers I have build tested themWill this be tested somehow by our automated tests? Cheers, Prabhakar Best regards, Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
|
|