Re: [RFC PATCH 4.19.y-cip 41/50] PCI: rcar: Add endpoint mode support
Lad Prabhakar
Hi Pavel,
toggle quoted messageShow quoted text
Thank you for the review.
-----Original Message-----Yep Agreed.+memset(&win, 0x0, sizeof(win));Plain 0 would be enough Ill post patches upstream to fix this and then backport or do you want me to do the changes in place ? Indeed a sleep is needed but checkpatch complains about it so usleep_range() was added.+val |= ASTINTX;This is crazy. Either you need exact timing or you don't, but I don't Cheers, Prabhakar Best regards, Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
|
|