Re: [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC


Biju Das <biju.das.jz@...>
 

Subject: Re: [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1
clock for CRTC

Hi!

On D3 and E3 platforms, the LVDS encoder includes a PLL that can
generate a clock for the corresponding CRTC, used even when the
CRTC output to a non-LVDS port. This mechanism is supported by the
driver, but the implementation is broken in dual-link LVDS mode.
In that case, the LVDS1 drm_encoder is skipped, which causes a
crash when trying to access its bridge later on.

Fix this by storing bridge pointers internally instead of
retrieving them from the encoder. The rcar_du_device encoders
field isn't used anymore and can be dropped.
The patch looks okay to me. I'll test it and can apply it if it
works okay.

But I don't believe it is in our 5.10, so I'd like it to be
submitted for 5.10, too.
Applied and pushed out.
Thanks you.

Regards,
Biju

Join cip-dev@lists.cip-project.org to automatically receive all group messages.