Re: [isar-cip-dev][PATCH 2/2] swupdate: Add option to use swupdate-handler-roundrobin


Quirin Gylstorff
 

On 6/14/21 1:19 PM, Christian Storm via lists.cip-project.org wrote:
Hi Quirin,

--- a/recipes-core/images/files/secure-boot/sw-description.tmpl
+++ b/recipes-core/images/files/secure-boot/sw-description.tmpl
@@ -14,16 +14,22 @@ software =
name = "secure boot update"
images: ({
filename = "${ROOTFS_PARTITION_NAME}";
- device = "fedcba98-7654-3210-cafe-5e0710000001,fedcba98-7654-3210-cafe-5e0710000002";
+ device = "sda4,sda5";
Did you intentionally go from UIDs to PATHs?
Why not uniformly using UIDs?
This change was intentionally.

The `getroot` function in the new handler cannot use UUID if there is no root option in the kernel commandline.

As the initrd selects the root filesystem partition,the root option was not added to the kernel command line.

--- /dev/null
+++ b/recipes-core/swupdate/files/secureboot/swupdate.handler.efibootguard.ini
@@ -0,0 +1,20 @@
+[image]
+chainhandler=raw
+
+[image.selector]
+method=getroot_rr
+key=root
+
+[image.bootenv]
+ustate=1
Are you sure you really need setting ustate these days?
I missed that - It is no longer necessary. I will update in v2.

Kind regards,
Christian
Thanks for the review and Kind regards,
Quirin

Join cip-dev@lists.cip-project.org to automatically receive all group messages.