Re: [isar-cip-core][PATCH 2/2] kas/opt/efibootguard: Move setting of IMAGE_TYPE


Jan Kiszka <jan.kiszka@...>
 

On 28.09.21 20:49, Quirin Gylstorff wrote:
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

This seperates the image type from the boot loader.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
kas/opt/efibootguard.yml | 1 -
kas/opt/wic-img.yml | 19 +++++++++++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
create mode 100644 kas/opt/wic-img.yml

diff --git a/kas/opt/efibootguard.yml b/kas/opt/efibootguard.yml
index 705a76d..4e8be69 100644
--- a/kas/opt/efibootguard.yml
+++ b/kas/opt/efibootguard.yml
@@ -23,6 +23,5 @@ local_conf_header:
efibootguard-wic: |
WDOG_TIMEOUT ?= "60"
WICVARS += "WDOG_TIMEOUT"
- IMAGE_TYPE ?= "wic-img"
WKS_FILE ?= "${MACHINE}-${SWUPDATE_BOOTLOADER}.wks"

diff --git a/kas/opt/wic-img.yml b/kas/opt/wic-img.yml
new file mode 100644
index 0000000..2b02b42
--- /dev/null
+++ b/kas/opt/wic-img.yml
@@ -0,0 +1,19 @@
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Siemens AG, 2021
+#
+# Authors:
+# Quirin Gylstorff <quirin.gylstorff@siemens.com>
+#
+# SPDX-License-Identifier: MIT
+#
+# This kas file set the IMAGE_TYPE to wic-img
+# The device specific WKS_FILE needs to be set seperately.
+
+header:
+ version: 10
+
+local_conf_header:
+ image-type: |
+ IMAGE_TYPE = "wic-img"
What's the purpose of this file? When should a user specify this option?
I think we already have too many option files and rather need to reduce
them than adding more.

Jan

PS: Something is currently off with archiving on lore.kernel.org.
Messages from this thread but also others appear twice there:
https://lore.kernel.org/cip-dev/20210928184946.GHmZQFBkA_wEzR1iQiB_04frBV52DnaYGHOSYtAdjok@z/T/#t

Join cip-dev@lists.cip-project.org to automatically receive all group messages.