Re: [isar-cip-core][RFC PATCH] customizations: Add FW and tools required for wifi testing


Lad Prabhakar
 

Hi Jan,

Thank you for the quick response.

-----Original Message-----
From: Jan Kiszka <jan.kiszka@siemens.com>
Sent: 22 November 2021 11:28
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; cip-dev@lists.cip-project.org;
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
Subject: Re: [cip-dev][isar-cip-core][RFC PATCH] customizations: Add FW and tools required for wifi
testing

On 22.11.21 12:19, Lad Prabhakar wrote:
Add firmware and tools required for testing wifin on hihope-rzg2m.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Hi All,

Sending an RFC as I am not sure if this is the right place to add
this. I wanted to add the debian package depends in machine.conf file
but didnt find any variables.
IMAGE_INSTALL_append would work there, see eg.
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsiemens%2Fjailhouse-
images%2Fblob%2Fmaster%2Fconf%2Fmachine%2Frpi4.conf&amp;data=04%7C01%7Cprabhakar.mahadev-
lad.rj%40bp.renesas.com%7Cae2601f49f5b4725b1ab08d9adab1943%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%
7C637731772644808211%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
CI6Mn0%3D%7C3000&amp;sdata=mqp0wknGyxKyY82YvgHJXl72aTu4DWSuUOHcaZPo8xA%3D&amp;reserved=0.
Adding IMAGE_INSTALL/IMAGE_PREINSTALL machine.conf didn’t help for me, I was seeing below issues:

| ERROR: Nothing PROVIDES 'wireless-regdb' (but /repo/recipes-core/images/cip-core-image.bb DEPENDS on or otherwise requires it)
| ERROR: Required build target 'cip-core-image' has no buildable providers.
| Missing or unbuildable dependency chain was: ['cip-core-image', 'wireless-regdb']

| ERROR: Nothing PROVIDES 'wireless-tools' (but /repo/recipes-core/images/cip-core-image.bb DEPENDS on or otherwise requires it)
| ERROR: Required build target 'cip-core-image' has no buildable providers.
| Missing or unbuildable dependency chain was: ['cip-core-image', 'wireless-tools']

| ERROR: Nothing PROVIDES 'firmware-ti-connectivity' (but /repo/recipes-core/images/cip-core-image.bb DEPENDS on or otherwise requires it)
| ERROR: Required build target 'cip-core-image' has no buildable providers.
| Missing or unbuildable dependency chain was: ['cip-core-image', 'firmware-ti-connectivity']

| ERROR: Nothing PROVIDES 'iw' (but /repo/recipes-core/images/cip-core-image.bb DEPENDS on or otherwise requires it)
| ERROR: Required build target 'cip-core-image' has no buildable providers.
| Missing or unbuildable dependency chain was: ['cip-core-image', 'iw']

As above didn’t work and customizations.bb is the only place were I was able to grep for DEBIAN_DEPENDS variable I went this approach 😉.
(Note also adding DEBIAN_DEPENDS in machine.conf didn’t work.)

Is there something which I am missing that would make it work with IMAGE_INSTALL_append variable?


Whether we want to "hard-code" the installation wireless firmware in the machine conf here is a
different question. Maybe customizations is not that a bad place.
If adding IMAGE_INSTALL_append works in machine.conf, will go with this approach, as that would not disturb other platform builds.


Is this the right place for adding this, if not could you please point
me to the right direction.

** Do not merge this patch **

Cheers,
Prabhakar
---
recipes-core/customizations/customizations.bb | 3 +++
1 file changed, 3 insertions(+)

diff --git a/recipes-core/customizations/customizations.bb
b/recipes-core/customizations/customizations.bb
index 932b11c..c508fd4 100644
--- a/recipes-core/customizations/customizations.bb
+++ b/recipes-core/customizations/customizations.bb
@@ -23,6 +23,9 @@ DEPENDS += "sshd-regen-keys"
DEBIAN_DEPENDS = " \
ifupdown, isc-dhcp-client, net-tools, iputils-ping, ssh, sshd-regen-keys"

+DEBIAN_DEPENDS_hihope-rzg2m += " \
+ ,firmware-ti-connectivity, iw, wireless-regdb, wireless-tools"
+
Let's already prepare for other targets requesting the generic wireless tools as well: Put them into a
reusable variable and then add that variable here.
So just appending DEBIAN_DEPENDS above here in this file should be OK for all the platforms?

Cheers,
Prabhakar

Jan

do_install() {
install -v -d ${D}/etc/network/interfaces.d
install -v -m 644 ${WORKDIR}/ethernet ${D}/etc/network/interfaces.d/
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Join cip-dev@lists.cip-project.org to automatically receive all group messages.