Re: [isar-cip-core][PATCH 0/4] Add cip-core-image-kernelci building and uploading system


Jan Kiszka
 

On 07.01.22 11:19, Alice Ferrazzi wrote:
On Fri, Jan 7, 2022 at 7:11 PM Jan Kiszka <jan.kiszka@...> wrote:

On 07.01.22 10:57, Alice Ferrazzi wrote:
On Thu, Jan 6, 2022 at 11:18 PM Jan Kiszka <jan.kiszka@...> wrote:

On 06.01.22 12:16, Alice Ferrazzi wrote:
This patch series add a new image with settings for
KernelCI.

This new image is called cip-core-image-kernelci and is
based on isar-cip-core general image with some changes
needed for make it work with KernelCI and taken from
KernelCI image base settings.
The cip-core-image-kernelci images are built by GitlabCI
and uploaded to KernelCI production fileserver.
https://storage.kernelci.org/images/rootfs/cip/

These patches are already integrated in the
isar-cip-core:alicef/kernelci_master_refactor repository branch
and are generating the images that are currently
used by KernelCI.

cip-core-image-kernelci as been tested and are
already used in KernelCI production with good results.
https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/
Thanks a lot for enabling this!

One meta-question: How does this image relate to what happens to a
standard image when adding kas/opt/test.yml? Does
kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former
actually include the latter?
Currently it doesn't make too much sense to add such testing packages.
CIP kernel image testing is done using ad-hoc images with a KernelCI
built version of the
testing packages for having a common base and better compare results
with other kernels.
cip-core-image-kernelci is currently tested as booting image with
dmesg checks for each kernel (but still using specific KernelCI
configurations and scripts).
We are currently trying to implement the iec-security test as user
space test that will use cip-core-image-kernelci,
I sent a pull request for implementing the user space test
iec-security but is still in progress.
Because KernelCI testings and test environments differs from CIP
gitlab pipeline test environment,
we have to use a different file and merging both would currently make
such different environments unstable.

I hope that this answer your question.
Ok, we just need to keep an eye on target configs and options that deal
with "testing" so that things are consistent and intuitive.


These things you may ask yourself when try to add the image also to our
Kconfig menu ("kas-container menu"). That would be nice to have for a v3
as well, but more important is sorting out the option relationships.
cip-core-image-kernelci are build using gitlab pipeline and there is
currently no benefit to have such
images manual build.
So, the case that a test fails on kernel CI and someone want to
reproduce the image that triggered this does not exist? One would rather
build a regular image for the target then?
Why not just using the pre made image from
https://storage.kernelci.org/images/rootfs/cip/
for reproducing errors ?
Fine, as long as you do not need to adjust things in it afterwards.
Granted, such cases will be less common.

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux

Join cip-dev@lists.cip-project.org to automatically receive all group messages.