Re: [PATCH 5.10.y-cip 11/29] watchdog: Add Watchdog Timer driver for RZ/G2L


Lad Prabhakar
 

Hi Pavel,

Thank you for the review.

-----Original Message-----
From: Pavel Machek <pavel@...>
Sent: 05 April 2022 20:00
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...>
Cc: cip-dev@...; Nobuhiro Iwamatsu
<nobuhiro1.iwamatsu@...>; Pavel Machek <pavel@...>; Biju Das
<biju.das.jz@...>
Subject: Re: [PATCH 5.10.y-cip 11/29] watchdog: Add Watchdog Timer driver
for RZ/G2L

Hi!

From: Biju Das <biju.das.jz@...>

commit 2cbc5cd0b55fa2310cc557c77b0665f5e00272de upstream.

Add Watchdog Timer driver for RZ/G2L SoC.

WDT IP block supports normal watchdog timer function and reset request
function due to CPU parity error.

This driver currently supports normal watchdog timer function and
later will add support for reset request function due to CPU parity
error.
+static int rzg2l_wdt_start(struct watchdog_device *wdev) {
+ struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev);
+
+ reset_control_deassert(priv->rstc);
+ pm_runtime_get_sync(wdev->parent);
+
+ /* Initialize time out */
+ rzg2l_wdt_init_timeout(wdev);
+
+ /* Initialize watchdog counter register */
+ rzg2l_wdt_write(priv, 0, WDTTIM);
+
+ /* Enable watchdog timer*/
I'd put space before */.
Agreed.

+ ret = pm_runtime_resume_and_get(&pdev->dev);
+ if (ret < 0) {
+ dev_err(dev, "pm_runtime_resume_and_get failed ret=%pe",
ERR_PTR(ret));
+ goto out_pm_get;
+ }
...
+ watchdog_set_drvdata(&priv->wdev, priv);
+ ret = devm_add_action_or_reset(&pdev->dev,
+ rzg2l_wdt_reset_assert_pm_disable_put,
+ &priv->wdev);
+ if (ret < 0)
+ return ret;
I believe you need to undo effects of pm_runtime_resume_and_get() here and
jump to out_pm_get.
Right, for upstream the patch has been already sent out once its part of -rc release I will backport it to CIP.

Cheers,
Prabhakar

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join cip-dev@lists.cip-project.org to automatically receive all group messages.