Re: [PATCH 5.10.y-cip 03/24] ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel configuration parameter


Lad Prabhakar
 

Hi Pavel,

Thank you for the review.

-----Original Message-----
From: Pavel Machek <pavel@...>
Sent: 21 April 2022 09:33
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...>
Cc: cip-dev@...; Nobuhiro Iwamatsu
<nobuhiro1.iwamatsu@...>; Pavel Machek <pavel@...>; Biju Das
<biju.das.jz@...>
Subject: Re: [PATCH 5.10.y-cip 03/24] ASoC: dt-bindings: renesas,rz-ssi:
Update slave dma channel configuration parameter

Hi!

.../bindings/sound/renesas,rz-ssi.yaml | 22 +++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)

diff --git
a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
index 471937cb8d05..414ff8035a4e 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
@@ -48,6 +48,24 @@ properties:
dmas:
minItems: 1
maxItems: 2
+ description:
+ The first cell represents a phandle to dmac
I would not mind . at the end of the sentence, to be consistent with the
next paragraph, but that's really a nitpicking.
Do agree, if there are any updates to this file upstream I will update it.

Cheers,
Prabhakar

+ The second cell specifies the encoded MID/RID values of the SSI
port
+ connected to the DMA client and the slave channel configuration
+ parameters.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join cip-dev@lists.cip-project.org to automatically receive all group messages.