Re: [PATCH 5.10.y-cip 04/24] ASoC: sh: Add RZ/G2L SSIF-2 driver


Lad Prabhakar
 

Hi Pavel,

-----Original Message-----
From: Pavel Machek <pavel@...>
Sent: 21 April 2022 12:03
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...>
Cc: nobuhiro1.iwamatsu@...; cip-dev@...;
pavel@...; Biju Das <biju.das.jz@...>
Subject: Re: [PATCH 5.10.y-cip 04/24] ASoC: sh: Add RZ/G2L SSIF-2 driver

Hi!

I guess there was two comments hidden in the quoted text. I'm not sure if
you noticed them?
Thanks, I had missed them.

Best regards,
Pavel

+#define SSIFSR_TDC_MASK 0x3f
+#define SSIFSR_TDC_SHIFT 24
+#define SSIFSR_RDC_MASK 0x3f
+#define SSIFSR_RDC_SHIFT 8
+
+#define SSIFSR_TDC(x) (((x) & 0x1f) << 24)
This is not used.
If you use it, you can use SSIFSR_TDC_SHIFT and SSIFSR_TDC_MASK.
Agreed.

+#define SSIFSR_TDE BIT(16)
+#define SSIFSR_RDC(x) (((x) & 0x1f) << 8)
Same above.
Ditto.

Cheers,
Prabhakar

Join cip-dev@lists.cip-project.org to automatically receive all group messages.