Re: [PATCH RESEND 5.10.y-cip 01/13] kernel.h: split out mathematical helpers


Biju Das
 

Hi Pavel,

Thanks for the feedback.

Subject: Re: [PATCH RESEND 5.10.y-cip 01/13] kernel.h: split out
mathematical helpers

Hi!

From: Andy Shevchenko <andriy.shevchenko@...>

commit aa6159ab99a9ab5df835b4750b66cf132a5aa292 upstream

kernel.h is being used as a dump for all kinds of stuff for a long
time.
Here is the attempt to start cleaning it up by splitting out
mathematical helpers.

At the same time convert users in header and lib folder to use new
header. Though for time being include new header back to kernel.h to
avoid twisted indirected includes for existing users.
This is rather intrusive for two lines which we really need, and may
cause rejects in future.

I'd suggest identifying the defines needed by the driver, and just adding
those. kernel.h would be acceptable. Or you can add math.h with just
defines needed, but please avoid code movement.
OK, will send v2. By adding needed defines in kernel.h and replacing driver include
math.h->kernel.h

Cheers,
Biju


---
fs/nfs/callback_proc.c | 5 +
include/linux/bitops.h | 11 ++-
include/linux/dcache.h | 1 +
include/linux/iommu-helper.h | 4 +-
include/linux/kernel.h | 173 +--------------------------------
include/linux/math.h | 177 ++++++++++++++++++++++++++++++++++
include/linux/rcu_node_tree.h | 2 +
include/linux/units.h | 2 +-
lib/errname.c | 1 +
lib/errseq.c | 1 +
lib/find_bit.c | 3 +-
lib/math/div64.c | 4 +-
lib/math/int_pow.c | 2 +-
lib/math/int_sqrt.c | 3 +-
lib/math/reciprocal_div.c | 9 +-
15 files changed, 215 insertions(+), 183 deletions(-) create mode
100644 include/linux/math.h


--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Join cip-dev@lists.cip-project.org to automatically receive all group messages.