-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 12, 2020 12:56 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ) <kazuhiro3.hayashi@...>;
dinesh kumar(ＴＳＩＰ DS Company) <dinesh.kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hello Kazu-san,

I observed 'init' system is not included in the image when append
operator is not used and so booting the image is not successful.

Here is the output of `bitbake -e cip-core-image-security | grep
'IMAGE_PREINSTALL'` when append is not used
----------------------------------------------------------------------
---------------------------
# $IMAGE_PREINSTALL [2 operations]
IMAGE_PREINSTALL=" openssl libssl1.1 fail2ban openssh-server openssh-sftp-server openssh-client
syslog-ng-core syslog-ng-mod-journal aide aide-common libnftables0 nftables libpam-pkcs11
chrony tpm2-tools tpm2-abrmd libtss2-esys0 libtss2-udev libpam-cracklib acl
libauparse0 audispd-plugins auditd uuid-runtime vim "
# "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
# " ${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
----------------------------------------------------------------------
---------------------------

Output when append is used
----------------------------------------------------------------------
---------------------------
# $IMAGE_PREINSTALL [2 operations]
IMAGE_PREINSTALL=" init openssl libssl1.1 fail2ban openssh-server openssh-sftp-server
openssh-client syslog-ng-core syslog-ng-mod-journal aide aide-common libnftables0 nftables
libpam-pkcs11 chrony tpm2-tools tpm2-abrmd libtss2-esys0 libtss2-udev libpam-cracklib
acl libauparse0 audispd-plugins auditd uuid-runtime vim "
# "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
# " ${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
----------------------------------------------------------------------
---------------------------


Thanks,
Venkata.
-----Original Message-----
From: kazuhiro3.hayashi@...
[mailto:kazuhiro3.hayashi@...]
Sent: 12 March 2020 05:16
To: Venkata Seshagiri Pyla <Venkata.Pyla@...>; Dinesh
Kumar <Dinesh.Kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hello Venkata,

Thank you for the information.

Regarding the usage of `IMAGE_PREINSTALL`, I'm not sure if we always need `+` in the image recipe.
Example:
https://github.com/ilbers/isar/blob/master/doc/user_manual.md#create-a
-custom-image-recipe Could you dump the value of `IMAGE_PREINSTALL`
with/without `+` by `bitbake -e` command?

Best regards,
Kazu

-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 5, 2020 6:06 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ)
<kazuhiro3.hayashi@...>;
dinesh kumar(ＴＳＩＰ DS Company) <dinesh.kumar@...>
Cc: cip-security@...;
cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

I have created the image with all proposed security packages included.
applied the below change, and booted the image in QEMU correctly.
-----------------
diff --git a/recipes-core/images/cip-core-image-security.bb
b/recipes-core/images/cip-core-image-security.bb
index 70571f8..b883414 100644
--- a/recipes-core/images/cip-core-image-security.bb
+++ b/recipes-core/images/cip-core-image-security.bb
@@ -18,7 +18,7 @@ IMAGE_INSTALL += "customizations"

# Debian packages that provide security features # TODO: Add sudo
or sudo-ldap which conflict each other -IMAGE_PREINSTALL = " \
+IMAGE_PREINSTALL += " \
openssl libssl1.1 \
fail2ban \
openssh-server openssh-sftp-server openssh-client \
--
-----------------

Thanks
venkata
-----Original Message-----
From: Venkata Seshagiri Pyla
Sent: 02 March 2020 19:38
To: Dinesh Kumar <Dinesh.Kumar@...>;
kazuhiro3.hayashi@...
Cc: cip-security@...;
cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages

are included in the given source?

If it is included, could you please let us know how to install them in the image?

I think we have to create the image for the target "cip-core-image-security" instead of "cip-core-image".

All the security packages are configured to install are present in this file "cip-core-image-security.bb".

I will generate the image for target "cip-core-image-security" and recheck all the security functionality.

Thanks,
Venkata.

-----Original Message-----
From: Cip-security
[mailto:cip-security-bounces@...]
On Behalf Of Dinesh Kumar
Sent: 02 March 2020 15:29
To: kazuhiro3.hayashi@...
Cc: cip-security@...;
cip-dev@...
Subject: Re: [Cip-security] Sample image including security packages

Dear Kazu-san,

Thanks for sharing the isar-cip-core repository details with us.

We followed below steps to first confirm whether all the proposed
binaries are included when we create CIP isar based image.
1. Create CIP isar based image from
"https://gitlab.com/zuka0828/isar-cip-core/-/tree/master" for
QEMU_x86-64 platform 2. Booted the image in QEMU virtual machine 3.
For each security package we compared the binaries

listed on Debian page e.g. for acl package at
(https://packages.debian.org/buster/amd64/acl/filelist)

According to the Debian page there are three binaries which
should be present in the image "/bin/chacl", "/bin/getfacl", "/bin/setfacl".
Then we check in the CIP running image at /bin whether all three packages are included or not.
4. Based on this kind of investigation we have prepare the attached
list of missing binary packages in current CIP isar image.

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages are included in the given source?
If it is included, could you please let us know how to install them in the image?

Once all the security packages are included in the CIP isar image,
we will proceed to next step of verifying applicable IEC 62443-4-2 security requirements.

Thanks & Regards,
Dinesh Kumar


-----Original Message-----
From: Cip-security <cip-security-bounces@...> On
Behalf Of kazuhiro3.hayashi@...
Sent: 21 February 2020 10:58
To: cip-security@...
Cc: cip-dev@...
Subject: [Cip-security] Sample image including security packages

Hello CIP Security WG,

I've created a sample setting to customize CIP Core generic profile.
https://gitlab.com/zuka0828/isar-cip-core/-/tree/master
(Now in my personal account)

Introduction:
https://gitlab.com/zuka0828/isar-cip-core/-/blob/master/SECURITY.md

Please ask in cip-dev if you need more development information :)

Note: `sudo` and `sudo-ldap` conflict each other, but both were proposed.
We need to select one from them.
I temporally removed the both from `IMAGE_PREINSTALL`.

Best regards,
Kazu

_______________________________________________
Cip-security mailing list
Cip-security@...
https://lists.cip-project.org/mailman/listinfo/cip-security
The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices.
You should not disclose, copy or otherwise use the information
contained in the message or any annexure. Any views expressed in
this e-mail are those of the individual sender except where the

sender specifically states them to be the views of Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be
free of any virus or other defect that might affect any computer
system into which it is received and opened, it is the
responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by Toshiba Embedded Software India Pvt.

Ltd, for any loss or damage arising in any way from its use.

The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and
may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices.
You should not disclose, copy or otherwise use the information
contained in the message or any annexure. Any views expressed in
this e-mail are those of the individual sender except where the
sender specifically states them to be the views of Toshiba Software India Pvt. Ltd.
(TSIP),Bangalore.

Although this transmission and any attachments are believed to be
free of any virus or other defect that might affect any computer
system into which it is received and opened, it is the
responsibility of the recipient to ensure that it is virus free and
no responsibility is accepted by Toshiba Embedded Software India
Pvt. Ltd, for any loss or damage arising in any way from its use.

The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and
may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices. You
should not disclose, copy or otherwise use the information contained
in the message or any annexure. Any views expressed in this e-mail are
those of the individual sender except where the sender specifically
states them to be the views of Toshiba Software India Pvt. Ltd.
(TSIP),Bangalore.

Although this transmission and any attachments are believed to be free
of any virus or other defect that might affect any computer system
into which it is received and opened, it is the responsibility of the
recipient to ensure that it is virus free and no responsibility is
accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or
damage arising in any way from its use.

-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 12, 2020 12:56 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ) <kazuhiro3.hayashi@...>; dinesh kumar(ＴＳＩＰ DS Company)
<dinesh.kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hello Kazu-san,

I observed 'init' system is not included in the image when append operator is not used and so booting the image is not
successful.

Here is the output of `bitbake -e cip-core-image-security | grep 'IMAGE_PREINSTALL'` when append is not used
-------------------------------------------------------------------------------------------------
# $IMAGE_PREINSTALL [2 operations]
IMAGE_PREINSTALL=" openssl libssl1.1 fail2ban openssh-server openssh-sftp-server openssh-client
syslog-ng-core syslog-ng-mod-journal aide aide-common libnftables0 nftables libpam-pkcs11
chrony tpm2-tools tpm2-abrmd libtss2-esys0 libtss2-udev libpam-cracklib acl
libauparse0 audispd-plugins auditd uuid-runtime vim "
# "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
# " ${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
-------------------------------------------------------------------------------------------------

Output when append is used
-------------------------------------------------------------------------------------------------
# $IMAGE_PREINSTALL [2 operations]
IMAGE_PREINSTALL=" init openssl libssl1.1 fail2ban openssh-server openssh-sftp-server
openssh-client syslog-ng-core syslog-ng-mod-journal aide aide-common libnftables0 nftables
libpam-pkcs11 chrony tpm2-tools tpm2-abrmd libtss2-esys0 libtss2-udev libpam-cracklib
acl libauparse0 audispd-plugins auditd uuid-runtime vim "
# "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
# " ${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
-------------------------------------------------------------------------------------------------


Thanks,
Venkata.
-----Original Message-----
From: kazuhiro3.hayashi@... [mailto:kazuhiro3.hayashi@...]
Sent: 12 March 2020 05:16
To: Venkata Seshagiri Pyla <Venkata.Pyla@...>; Dinesh Kumar <Dinesh.Kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hello Venkata,

Thank you for the information.

Regarding the usage of `IMAGE_PREINSTALL`, I'm not sure if we always need `+` in the image recipe.
Example: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#create-a-custom-image-recipe
Could you dump the value of `IMAGE_PREINSTALL` with/without `+` by `bitbake -e` command?

Best regards,
Kazu

-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 5, 2020 6:06 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ) <kazuhiro3.hayashi@...>;
dinesh kumar(ＴＳＩＰ DS Company) <dinesh.kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

I have created the image with all proposed security packages included.
applied the below change, and booted the image in QEMU correctly.
-----------------
diff --git a/recipes-core/images/cip-core-image-security.bb
b/recipes-core/images/cip-core-image-security.bb
index 70571f8..b883414 100644
--- a/recipes-core/images/cip-core-image-security.bb
+++ b/recipes-core/images/cip-core-image-security.bb
@@ -18,7 +18,7 @@ IMAGE_INSTALL += "customizations"

# Debian packages that provide security features # TODO: Add sudo or
sudo-ldap which conflict each other -IMAGE_PREINSTALL = " \
+IMAGE_PREINSTALL += " \
openssl libssl1.1 \
fail2ban \
openssh-server openssh-sftp-server openssh-client \
--
-----------------

Thanks
venkata
-----Original Message-----
From: Venkata Seshagiri Pyla
Sent: 02 March 2020 19:38
To: Dinesh Kumar <Dinesh.Kumar@...>;
kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages

are included in the given source?

If it is included, could you please let us know how to install them in the image?

I think we have to create the image for the target "cip-core-image-security" instead of "cip-core-image".

All the security packages are configured to install are present in this file "cip-core-image-security.bb".

I will generate the image for target "cip-core-image-security" and recheck all the security functionality.

Thanks,
Venkata.

-----Original Message-----
From: Cip-security [mailto:cip-security-bounces@...]
On Behalf Of Dinesh Kumar
Sent: 02 March 2020 15:29
To: kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: Re: [Cip-security] Sample image including security packages

Dear Kazu-san,

Thanks for sharing the isar-cip-core repository details with us.

We followed below steps to first confirm whether all the proposed
binaries are included when we create CIP isar based image.
1. Create CIP isar based image from
"https://gitlab.com/zuka0828/isar-cip-core/-/tree/master" for
QEMU_x86-64 platform 2. Booted the image in QEMU virtual machine 3. For each security package we compared the binaries

listed on Debian page e.g. for acl package at (https://packages.debian.org/buster/amd64/acl/filelist)

According to the Debian page there are three binaries which
should be present in the image "/bin/chacl", "/bin/getfacl", "/bin/setfacl".
Then we check in the CIP running image at /bin whether all three packages are included or not.
4. Based on this kind of investigation we have prepare the attached
list of missing binary packages in current CIP isar image.

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages are included in the given source?
If it is included, could you please let us know how to install them in the image?

Once all the security packages are included in the CIP isar image, we
will proceed to next step of verifying applicable IEC 62443-4-2 security requirements.

Thanks & Regards,
Dinesh Kumar


-----Original Message-----
From: Cip-security <cip-security-bounces@...> On
Behalf Of kazuhiro3.hayashi@...
Sent: 21 February 2020 10:58
To: cip-security@...
Cc: cip-dev@...
Subject: [Cip-security] Sample image including security packages

Hello CIP Security WG,

I've created a sample setting to customize CIP Core generic profile.
https://gitlab.com/zuka0828/isar-cip-core/-/tree/master
(Now in my personal account)

Introduction:
https://gitlab.com/zuka0828/isar-cip-core/-/blob/master/SECURITY.md

Please ask in cip-dev if you need more development information :)

Note: `sudo` and `sudo-ldap` conflict each other, but both were proposed.
We need to select one from them.
I temporally removed the both from `IMAGE_PREINSTALL`.

Best regards,
Kazu

_______________________________________________
Cip-security mailing list
Cip-security@...
https://lists.cip-project.org/mailman/listinfo/cip-security
The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices. You
should not disclose, copy or otherwise use the information contained
in the message or any annexure. Any views expressed in this e-mail are those of the individual sender except where the

sender specifically states them to be the views of Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be free
of any virus or other defect that might affect any computer system
into which it is received and opened, it is the responsibility of the
recipient to ensure that it is virus free and no responsibility is accepted by Toshiba Embedded Software India Pvt.

Ltd, for any loss or damage arising in any way from its use.

The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and
may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices. You
should not disclose, copy or otherwise use the information contained
in the message or any annexure. Any views expressed in this e-mail are
those of the individual sender except where the sender specifically
states them to be the views of Toshiba Software India Pvt. Ltd.
(TSIP),Bangalore.

Although this transmission and any attachments are believed to be free
of any virus or other defect that might affect any computer system
into which it is received and opened, it is the responsibility of the
recipient to ensure that it is virus free and no responsibility is
accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or
damage arising in any way from its use.

The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the
recipient and may contain privileged information.
If you are not the intended recipient, please notify the
sender and delete the message along with any
attachments/annexure/appendices. You should not disclose,
copy or otherwise use the information contained in the
message or any annexure. Any views expressed in this e-mail
are those of the individual sender except where the sender
specifically states them to be the views of
Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be
free of any virus or other defect that might affect any computer
system into which it is received and opened, it is the responsibility
of the recipient to ensure that it is virus free and no responsibility
is accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or
damage arising in any way from its use.

-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 5, 2020 6:06 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ) <kazuhiro3.hayashi@...>;
dinesh kumar(ＴＳＩＰ DS Company) <dinesh.kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

I have created the image with all proposed security packages included.
applied the below change, and booted the image in QEMU correctly.
-----------------
diff --git a/recipes-core/images/cip-core-image-security.bb
b/recipes-core/images/cip-core-image-security.bb
index 70571f8..b883414 100644
--- a/recipes-core/images/cip-core-image-security.bb
+++ b/recipes-core/images/cip-core-image-security.bb
@@ -18,7 +18,7 @@ IMAGE_INSTALL += "customizations"

# Debian packages that provide security features # TODO: Add sudo or
sudo-ldap which conflict each other -IMAGE_PREINSTALL = " \
+IMAGE_PREINSTALL += " \
openssl libssl1.1 \
fail2ban \
openssh-server openssh-sftp-server openssh-client \
--
-----------------

Thanks
venkata
-----Original Message-----
From: Venkata Seshagiri Pyla
Sent: 02 March 2020 19:38
To: Dinesh Kumar <Dinesh.Kumar@...>;
kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages

are included in the given source?

If it is included, could you please let us know how to install them in the image?

I think we have to create the image for the target "cip-core-image-security" instead of "cip-core-image".

All the security packages are configured to install are present in this file "cip-core-image-security.bb".

I will generate the image for target "cip-core-image-security" and recheck all the security functionality.

Thanks,
Venkata.

-----Original Message-----
From: Cip-security [mailto:cip-security-bounces@...]
On Behalf Of Dinesh Kumar
Sent: 02 March 2020 15:29
To: kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: Re: [Cip-security] Sample image including security packages

Dear Kazu-san,

Thanks for sharing the isar-cip-core repository details with us.

We followed below steps to first confirm whether all the proposed
binaries are included when we create CIP isar based image.
1. Create CIP isar based image from
"https://gitlab.com/zuka0828/isar-cip-core/-/tree/master" for
QEMU_x86-64 platform 2. Booted the image in QEMU virtual machine 3. For each security package we compared the binaries listed on Debian page e.g. for acl package at (https://packages.debian.org/buster/amd64/acl/filelist)
According to the Debian page there are three binaries which
should be present in the image "/bin/chacl", "/bin/getfacl", "/bin/setfacl".
Then we check in the CIP running image at /bin whether all three packages are included or not.
4. Based on this kind of investigation we have prepare the attached
list of missing binary packages in current CIP isar image.

We found most of the packages are not included in the isar image,
could you please confirm whether all the proposed packages are included in the given source?
If it is included, could you please let us know how to install them in the image?

Once all the security packages are included in the CIP isar image, we
will proceed to next step of verifying applicable IEC 62443-4-2 security requirements.

Thanks & Regards,
Dinesh Kumar


-----Original Message-----
From: Cip-security <cip-security-bounces@...> On
Behalf Of kazuhiro3.hayashi@...
Sent: 21 February 2020 10:58
To: cip-security@...
Cc: cip-dev@...
Subject: [Cip-security] Sample image including security packages

Hello CIP Security WG,

I've created a sample setting to customize CIP Core generic profile.
https://gitlab.com/zuka0828/isar-cip-core/-/tree/master
(Now in my personal account)

Introduction:
https://gitlab.com/zuka0828/isar-cip-core/-/blob/master/SECURITY.md

Please ask in cip-dev if you need more development information :)

Note: `sudo` and `sudo-ldap` conflict each other, but both were proposed.
We need to select one from them.
I temporally removed the both from `IMAGE_PREINSTALL`.

Best regards,
Kazu

_______________________________________________
Cip-security mailing list
Cip-security@...
https://lists.cip-project.org/mailman/listinfo/cip-security
The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices. You
should not disclose, copy or otherwise use the information contained
in the message or any annexure. Any views expressed in this e-mail are those of the individual sender except where the sender specifically states them to be the views of Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be free
of any virus or other defect that might affect any computer system
into which it is received and opened, it is the responsibility of the
recipient to ensure that it is virus free and no responsibility is accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or damage arising in any way from its use.
The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the recipient and
may contain privileged information.
If you are not the intended recipient, please notify the sender and
delete the message along with any attachments/annexure/appendices. You
should not disclose, copy or otherwise use the information contained
in the message or any annexure. Any views expressed in this e-mail are
those of the individual sender except where the sender specifically
states them to be the views of Toshiba Software India Pvt. Ltd.
(TSIP),Bangalore.

Although this transmission and any attachments are believed to be free
of any virus or other defect that might affect any computer system
into which it is received and opened, it is the responsibility of the
recipient to ensure that it is virus free and no responsibility is
accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or
damage arising in any way from its use.

-----Original Message-----
From: Pavel Machek [mailto:pavel@...]
Sent: Tuesday, March 3, 2020 9:00 PM
To: iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ＯＳＴ)
<nobuhiro1.iwamatsu@...>
Subject: Re: How to handle diffs created in -rebase branch

Hi!

(I believe we should cc cip-dev for this discussion).

Commit 9c075d325ec23a9bd99b7097f0b82ec04b007093 [1] has this fix
in

v4.4.211, but commit edeed5f910db5962f4ecc097ad6d935a33041ee0 [2]
deletes the file once and commit
5a0d157b6153b462eabd8afcf827877e885336b9 [3] recreated the file.

If we rebase this, since the order of commits is 2, 3, 1 to 1,

2,

3, the above diffs was created.

I believe commit [1] is good, and we should not undo its effects
with other commits. Thus linux-4.4.y-cip is okay, and
linux-4.4.y-cip-rebase should be fixed. One way would be to
cherry-pick 1 into linux-4.4.y-cip-rebase.

I see, but commit [1] was already applied to v4.4.211 by upstream. So
the same commit is apply twice. Is this understanding same your suggest?

1. commit [1] / in v4.4.211
.....
x. commit / release v4.4.213
.....
x + 1. commit [2] / Delete fix by commit [1] / CIP's commit
x + 2. commit [3] / CIP's commit
x + 3. cherry-pick commit [1] <--- your suggest

-rebase branch is a branch that manages commits in the LTS tree and

CIP tree.

So a fix like this one always makes a difference.
I think there are two measures.

1. Ignore differences because it is a branch that manages commits.
2. If a difference occurs, commit to fix it. (Your suggestion)

I think that both are useful, but I want to get consensus with you as
kernel maintainers of CIP.

It is important for me for both branches to end up with same result.

"If a difference occurs, commit to fix it" is an acceptable solution to
it. But thinking about it some more, there may be even better one.

Central problem is that we delete fixed version of file, then re-create
the file without the fix. We should simply modify the re-creating patch
to create the fixed version.

If you want, I can try to do just that; but at the moment, current versions
do not seem to be on kernel.org:

4.4.213-based:
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/lo
g/?h=linux-4.4.y-cip
4.4.208-based:
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/lo
g/?h=linux-4.4.y-cip-rebase

-----Original Message-----
From: Venkata Seshagiri Pyla [mailto:Venkata.Pyla@...]
Sent: Thursday, March 5, 2020 6:06 PM
To: hayashi kazuhiro(林 和宏 ○ＳＷＣ□ＯＳＴ) <kazuhiro3.hayashi@...>; dinesh kumar(ＴＳＩＰ DS Company)
<dinesh.kumar@...>
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

I have created the image with all proposed security packages included.
applied the below change, and booted the image in QEMU correctly.
-----------------
diff --git a/recipes-core/images/cip-core-image-security.bb b/recipes-core/images/cip-core-image-security.bb
index 70571f8..b883414 100644
--- a/recipes-core/images/cip-core-image-security.bb
+++ b/recipes-core/images/cip-core-image-security.bb
@@ -18,7 +18,7 @@ IMAGE_INSTALL += "customizations"

# Debian packages that provide security features
# TODO: Add sudo or sudo-ldap which conflict each other
-IMAGE_PREINSTALL = " \
+IMAGE_PREINSTALL += " \
openssl libssl1.1 \
fail2ban \
openssh-server openssh-sftp-server openssh-client \
--
-----------------

Thanks
venkata
-----Original Message-----
From: Venkata Seshagiri Pyla
Sent: 02 March 2020 19:38
To: Dinesh Kumar <Dinesh.Kumar@...>; kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: RE: Sample image including security packages

Hi Kazu-san and Dinesh,

We found most of the packages are not included in the isar image, could you please confirm whether all the proposed packages

are included in the given source?

If it is included, could you please let us know how to install them in the image?

I think we have to create the image for the target "cip-core-image-security" instead of "cip-core-image".

All the security packages are configured to install are present in this file "cip-core-image-security.bb".

I will generate the image for target "cip-core-image-security" and recheck all the security functionality.

Thanks,
Venkata.

-----Original Message-----
From: Cip-security [mailto:cip-security-bounces@...] On Behalf Of Dinesh Kumar
Sent: 02 March 2020 15:29
To: kazuhiro3.hayashi@...
Cc: cip-security@...; cip-dev@...
Subject: Re: [Cip-security] Sample image including security packages

Dear Kazu-san,

Thanks for sharing the isar-cip-core repository details with us.

We followed below steps to first confirm whether all the proposed binaries are included when we create CIP isar based
image.
1. Create CIP isar based image from "https://gitlab.com/zuka0828/isar-cip-core/-/tree/master" for QEMU_x86-64 platform
2. Booted the image in QEMU virtual machine 3. For each security package we compared the binaries listed on Debian page
e.g. for acl package at (https://packages.debian.org/buster/amd64/acl/filelist)
According to the Debian page there are three binaries which should be present in the image "/bin/chacl", "/bin/getfacl",
"/bin/setfacl".
Then we check in the CIP running image at /bin whether all three packages are included or not.
4. Based on this kind of investigation we have prepare the attached list of missing binary packages in current CIP isar
image.

We found most of the packages are not included in the isar image, could you please confirm whether all the proposed packages
are included in the given source?
If it is included, could you please let us know how to install them in the image?

Once all the security packages are included in the CIP isar image, we will proceed to next step of verifying applicable
IEC 62443-4-2 security requirements.

Thanks & Regards,
Dinesh Kumar


-----Original Message-----
From: Cip-security <cip-security-bounces@...> On Behalf Of kazuhiro3.hayashi@...
Sent: 21 February 2020 10:58
To: cip-security@...
Cc: cip-dev@...
Subject: [Cip-security] Sample image including security packages

Hello CIP Security WG,

I've created a sample setting to customize CIP Core generic profile.
https://gitlab.com/zuka0828/isar-cip-core/-/tree/master
(Now in my personal account)

Introduction: https://gitlab.com/zuka0828/isar-cip-core/-/blob/master/SECURITY.md

Please ask in cip-dev if you need more development information :)

Note: `sudo` and `sudo-ldap` conflict each other, but both were proposed.
We need to select one from them.
I temporally removed the both from `IMAGE_PREINSTALL`.

Best regards,
Kazu

_______________________________________________
Cip-security mailing list
Cip-security@...
https://lists.cip-project.org/mailman/listinfo/cip-security
The information contained in this e-mail message and in any attachments/annexure/appendices is confidential to the recipient
and may contain privileged information.
If you are not the intended recipient, please notify the sender and delete the message along with any
attachments/annexure/appendices. You should not disclose, copy or otherwise use the information contained in the message
or any annexure. Any views expressed in this e-mail are those of the individual sender except where the sender specifically
states them to be the views of Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be free of any virus or other defect that might affect
any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it
is virus free and no responsibility is accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or damage arising
in any way from its use.
The information contained in this e-mail message and in any
attachments/annexure/appendices is confidential to the
recipient and may contain privileged information.
If you are not the intended recipient, please notify the
sender and delete the message along with any
attachments/annexure/appendices. You should not disclose,
copy or otherwise use the information contained in the
message or any annexure. Any views expressed in this e-mail
are those of the individual sender except where the sender
specifically states them to be the views of
Toshiba Software India Pvt. Ltd. (TSIP),Bangalore.

Although this transmission and any attachments are believed to be
free of any virus or other defect that might affect any computer
system into which it is received and opened, it is the responsibility
of the recipient to ensure that it is virus free and no responsibility
is accepted by Toshiba Embedded Software India Pvt. Ltd, for any loss or
damage arising in any way from its use.

Hi!

I pushed candidate for -cip-rt, but it seems to fail on de0-nano
board. Code under testing is at:

https://gitlab.com/cip-project/cip-kernel/linux-cip/tree/ci/pavel
/linux-cip

It is pipeline

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/1227
62401

I'll reuse the branch for more testing.

I managed to narrow the bad commit to the -rt tree, between:

OK 122904930 pick 69aa73357e6a rcu: Don't allow to change
rcu_normal_after_boot on RT pick 849ef8789077 pci/switchtec: fix
stream_open.cocci warnings pick ad8a5e8279c4 sched/core: Drop a
preempt_disable_rt() statement pick 966f066d96cb timers: Redo the
notification of canceling timers on -RT pick 0393fd5a4f9a Revert "futex: Ensure lock/unlock symetry versus pi_lock and hash bucket lock"
pick 84eb0b64a27a Revert "futex: Fix bug on when a requeued RT task times out"
pick fcc893280f4e Revert "rtmutex: Handle the various new futex race conditions"
pick 2eac93cf9d16 Revert "futex: workaround migrate_disable/enable in different context"
pick 9b8964629f4f futex: Make the futex_hash_bucket lock raw pick
cc1812bf198b futex: Delay deallocation of pi_state

pick f5e115c43100 mm/zswap: Do not disable preemption in
zswap_frontswap_store()

pick e0d0d09a08ad revert-aio
pick a0a40bfb4300 fs/aio: simple simple work pick 0fae581d8c5e
revert-thermal pick c0d95b4a8a1b thermal: Defer thermal wakups to
threads pick 700fbb4afb6e revert-block pick 4cda50ff12cf block:
blk-mq: move blk_queue_usage_counter_release() into process context
pick 9e982f55745b workqueue: rework pick c0db53dc3bf4 i2c: exynos5:
Remove IRQF_ONESHOT pick 1f160d170203 i2c: hix5hd2: Remove
IRQF_ONESHOT BAD 122882826 eae5a7cab722 sched/deadline: Ensure
inactive_timer runs in hardirq context

And something went seriously wrong after these tests. I submitted
same tree twice, and got different results.

First this -- de0-nano succeeds:

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/122904
930

Now this -- de0-nano fails (and ipc227e is unfinished for long time):

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/122959
477

I'll need some help here.

The logs read like the targets are not (always) coming up, e.g.
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/jobs/457824214#
L377

Yes... I don't need that target, but I need de0-nano... and it did not
work last time I checked.

On a related note... it would be good to somehow show difference
between "kernel test failure" and "target failure".

If we see bootloader in the logs, and then test fails/timeouts =>
"kernel test failure", I need to solve it.

If we don't get messages from the bootloader => "target failure",
someone needs to check the power relays or something...

Hi!

I pushed candidate for -cip-rt, but it seems to fail on de0-nano
board. Code under testing is at:

https://gitlab.com/cip-project/cip-kernel/linux-cip/tree/ci/pavel
/linux-cip

It is pipeline

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/1227
62401

I'll reuse the branch for more testing.

I managed to narrow the bad commit to the -rt tree, between:

OK 122904930 pick 69aa73357e6a rcu: Don't allow to change
rcu_normal_after_boot on RT pick 849ef8789077 pci/switchtec: fix
stream_open.cocci warnings pick ad8a5e8279c4 sched/core: Drop a
preempt_disable_rt() statement pick 966f066d96cb timers: Redo the
notification of canceling timers on -RT pick 0393fd5a4f9a Revert "futex: Ensure lock/unlock symetry versus pi_lock and hash bucket lock"
pick 84eb0b64a27a Revert "futex: Fix bug on when a requeued RT task times out"
pick fcc893280f4e Revert "rtmutex: Handle the various new futex race conditions"
pick 2eac93cf9d16 Revert "futex: workaround migrate_disable/enable in different context"
pick 9b8964629f4f futex: Make the futex_hash_bucket lock raw pick
cc1812bf198b futex: Delay deallocation of pi_state

pick f5e115c43100 mm/zswap: Do not disable preemption in
zswap_frontswap_store()

pick e0d0d09a08ad revert-aio
pick a0a40bfb4300 fs/aio: simple simple work pick 0fae581d8c5e
revert-thermal pick c0d95b4a8a1b thermal: Defer thermal wakups to
threads pick 700fbb4afb6e revert-block pick 4cda50ff12cf block:
blk-mq: move blk_queue_usage_counter_release() into process context
pick 9e982f55745b workqueue: rework pick c0db53dc3bf4 i2c: exynos5:
Remove IRQF_ONESHOT pick 1f160d170203 i2c: hix5hd2: Remove
IRQF_ONESHOT BAD 122882826 eae5a7cab722 sched/deadline: Ensure
inactive_timer runs in hardirq context

And something went seriously wrong after these tests. I submitted
same tree twice, and got different results.

First this -- de0-nano succeeds:

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/122904
930

Now this -- de0-nano fails (and ipc227e is unfinished for long time):

https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/122959
477

I'll need some help here.

The logs read like the targets are not (always) coming up, e.g.
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/jobs/457824214#
L377

Yes... I don't need that target, but I need de0-nano... and it did not
work last time I checked.

On a related note... it would be good to somehow show difference
between "kernel test failure" and "target failure".

If we see bootloader in the logs, and then test fails/timeouts =>
"kernel test failure", I need to solve it.

If we don't get messages from the bootloader => "target failure",
someone needs to check the power relays or something...

We found most of the packages are not included in the isar image, could you please confirm whether all the proposed packages are included in the given source?
If it is included, could you please let us know how to install them in the image?