|
[4.4.y-cip 10/15] PM / OPP: Set cpu_dev->id in cpumask first
Chen-Yu Tsai (Moxa) <wens@...>
From: Pi-Cheng Chen <pi-cheng.chen@...>
Set cpu_dev->id in cpumask first when setting up cpumask for CPUs that share the same OPP table. This might be helpful when handling cpumask without the original CPU bitfield set. Signed-off-by: Pi-Cheng Chen <pi-cheng.chen@...> Acked-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> --- drivers/base/power/opp/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c index 1a2e8f260b060..a0db8b3575f38 100644 --- a/drivers/base/power/opp/cpu.c +++ b/drivers/base/power/opp/cpu.c @@ -218,7 +218,6 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_of_cpumask_add_table); /* * Works only for OPP v2 bindings. * - * cpumask should be already set to mask of cpu_dev->id. * Returns -ENOENT if operating-points-v2 bindings aren't supported. */ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, cpumask_var_t= cpumask) @@ -234,6 +233,8 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu= _dev, cpumask_var_t cpumask return -ENOENT; } =20 + cpumask_set_cpu(cpu_dev->id, cpumask); + /* OPPs are shared ? */ if (!of_property_read_bool(np, "opp-shared")) goto put_cpu_node; --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1
Chen-Yu Tsai (Moxa) <wens@...>
Hi everyone,
This is part 1 of MOXA's PM / OPP / cpufreq backport series. The whole series aims to backport patches related to PM / OPPv2 and cpufreq which were included in the v4.4 kernel from TI's SDK. The end goal is to include cpufreq-ti and convert am33xx to using it and OPPv2. Part 1 here includes patches from the v4.5 cycle, listed in topological order: deaa51465105 PM / OPP: Add debugfs support 1c4d12de2719 PM / OPP: Add "opp-supported-hw" binding ffdb8cc7a27c PM / OPP: Add {opp-microvolt|opp-microamp}-<name> bindin= g af87a39a5f7c PM / OPP: Remove 'operating-points-names' binding 754dcf35f346 PM / OPP: Rename OPP nodes as opp@<opp-hz> dc4e7b1fa20a PM / OPP: Add missing doc comments 7de36b0aa51a PM / OPP: Parse 'opp-supported-hw' binding 01fb4d3c39d3 PM / OPP: Parse 'opp-<prop>-<name>' bindings fd8d8e63467c PM / OPP: Fix parsing of opp-microvolt and opp-microamp = properties d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first 5ff24d601092 PM / OPP: Use snprintf() instead of sprintf() 3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coeffic= ient property f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering co= oling devices 929ca89c305a cpufreq-dt: fix handling regulator_get_voltage() result b331bc20d928 cpufreq: cpufreq-dt: avoid uninitialized variable warnin= gs: Of these, dc4e7b1fa20a PM / OPP: Add missing doc comments was identified as a patch dependency, but otherwise serves no purpose. An= d d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first was found while looking through git logs. Last, 3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coeffic= ient property is related to f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering co= oling devices All other patches were included from TI's SDK. The patches apply cleanly on top of linux-4.4.y-cip. Please have a look. Regards ChenYu Andrzej Hajda (1): cpufreq-dt: fix handling regulator_get_voltage() result Arnd Bergmann (1): cpufreq: cpufreq-dt: avoid uninitialized variable warnings: Bartlomiej Zolnierkiewicz (1): PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties Pi-Cheng Chen (1): PM / OPP: Set cpu_dev->id in cpumask first Punit Agrawal (2): devicetree: bindings: Add optional dynamic-power-coefficient property cpufreq-dt: Supply power coefficient when registering cooling devices Viresh Kumar (9): PM / OPP: Add debugfs support PM / OPP: Add "opp-supported-hw" binding PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding PM / OPP: Remove 'operating-points-names' binding PM / OPP: Rename OPP nodes as opp@<opp-hz> PM / OPP: Add missing doc comments PM / OPP: Parse 'opp-supported-hw' binding PM / OPP: Parse 'opp-<prop>-<name>' bindings PM / OPP: Use snprintf() instead of sprintf() .../devicetree/bindings/arm/cpus.txt | 17 + Documentation/devicetree/bindings/opp/opp.txt | 132 +++++-- drivers/base/power/opp/Makefile | 1 + drivers/base/power/opp/core.c | 336 +++++++++++++++++- drivers/base/power/opp/cpu.c | 3 +- drivers/base/power/opp/debugfs.c | 219 ++++++++++++ drivers/base/power/opp/opp.h | 53 ++- drivers/cpufreq/cpufreq-dt.c | 29 +- include/linux/pm_opp.h | 22 ++ 9 files changed, 742 insertions(+), 70 deletions(-) create mode 100644 drivers/base/power/opp/debugfs.c --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 02/15] PM / OPP: Add "opp-supported-hw" binding
Chen-Yu Tsai (Moxa) <wens@...>
From: Viresh Kumar <viresh.kumar@...>
commit 1c4d12de2719dfdf27c6dab31e7a5641ee293c94 upstream. We may want to enable only a subset of OPPs, from the bigger list of OPPs, based on what version of the hardware we are running on. This would enable us to not duplicate OPP tables for every version of the hardware we support. To enable that, this patch defines a new property 'opp-supported-hw'. It can support any number of hierarchy levels of the versions the hardware follows. And based on the selected hardware versions, we can pick only the relevant OPPs at runtime. Reviewed-by: Stephen Boyd <sboyd@...> Acked-by: Rob Herring <robh@...> Signed-off-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- Documentation/devicetree/bindings/opp/opp.txt | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentatio= n/devicetree/bindings/opp/opp.txt index 0cb44dc21f97c..d072fa0ffbd44 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -123,6 +123,26 @@ Optional properties: - opp-suspend: Marks the OPP to be used during device suspend. Only one = OPP in the table should have this. =20 +- opp-supported-hw: This enables us to select only a subset of OPPs from= the + larger OPP table, based on what version of the hardware we are running= on. We + still can't have multiple nodes with the same opp-hz value in OPP tabl= e. + + It's an user defined array containing a hierarchy of hardware version = numbers, + supported by the OPP. For example: a platform with hierarchy of three = levels + of versions (A, B and C), this field should be like <X Y Z>, where X + corresponds to Version hierarchy A, Y corresponds to version hierarchy= B and Z + corresponds to version hierarchy C. + + Each level of hierarchy is represented by a 32 bit value, and so there= can be + only 32 different supported version per hierarchy. i.e. 1 bit per vers= ion. A + value of 0xFFFFFFFF will enable the OPP for all versions for that hier= archy + level. And a value of 0x00000000 will disable the OPP completely, and = so we + never want that to happen. + + If 32 values aren't sufficient for a version hierarchy, than that vers= ion + hierarchy can be contained in multiple 32 bit values. i.e. <X Y Z1 Z2>= in the + above example, Z1 & Z2 refer to the version hierarchy Z. + - status: Marks the node enabled/disabled. =20 Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states to= gether. @@ -463,3 +483,48 @@ Example 5: Multiple OPP tables }; }; }; + +Example 6: opp-supported-hw +(example: three level hierarchy of versions: cuts, substrate and process= ) + +/ { + cpus { + cpu@0 { + compatible =3D "arm,cortex-a7"; + ... + + cpu-supply =3D <&cpu_supply> + operating-points-v2 =3D <&cpu0_opp_table_slow>; + }; + }; + + opp_table { + compatible =3D "operating-points-v2"; + status =3D "okay"; + opp-shared; + + opp00 { + /* + * Supports all substrate and process versions for 0xF + * cuts, i.e. only first four cuts. + */ + opp-supported-hw =3D <0xF 0xFFFFFFFF 0xFFFFFFFF> + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <900000 915000 925000>; + ... + }; + + opp01 { + /* + * Supports: + * - cuts: only one, 6th cut (represented by 6th bit). + * - substrate: supports 16 different substrate versions + * - process: supports 9 different process versions + */ + opp-supported-hw =3D <0x20 0xff0000ff 0x0000f4f0> + opp-hz =3D /bits/ 64 <800000000>; + opp-microvolt =3D <900000 915000 925000>; + ... + }; + }; +}; --=20 2.27.0.rc0
|
|
|
|
Re: CVE-2020-10742 -- nfs client weirdness with max_rqst_size
Chen-Yu Tsai <wens@...>
Hi,
On Wed, Jun 3, 2020 at 11:28 PM Pavel Machek <pavel@...> wrote: SUSE reports it was introduced in v3.5 and fixed in v3.16. See https://bugzilla.suse.com/show_bug.cgi?id=1171984 . ChenYu I don't believe we need to do anything here.
|
|
|
|
[4.4.y-cip 15/15] cpufreq: cpufreq-dt: avoid uninitialized variable warnings:
Chen-Yu Tsai (Moxa) <wens@...>
From: Arnd Bergmann <arnd@...>
commit b331bc20d9281213f7fb67912638e0fb5baeb324 upstream. gcc warns quite a bit about values returned from allocate_resources() in cpufreq-dt.c: cpufreq-dt.c: In function 'cpufreq_init': cpufreq-dt.c:327:6: error: 'cpu_dev' may be used uninitialized in this fu= nction [-Werror=3Dmaybe-uninitialized] cpufreq-dt.c:197:17: note: 'cpu_dev' was declared here cpufreq-dt.c:376:2: error: 'cpu_clk' may be used uninitialized in this fu= nction [-Werror=3Dmaybe-uninitialized] cpufreq-dt.c:199:14: note: 'cpu_clk' was declared here cpufreq-dt.c: In function 'dt_cpufreq_probe': cpufreq-dt.c:461:2: error: 'cpu_clk' may be used uninitialized in this fu= nction [-Werror=3Dmaybe-uninitialized] cpufreq-dt.c:447:14: note: 'cpu_clk' was declared here The problem is that it's slightly hard for gcc to follow return codes across PTR_ERR() calls. This patch uses explicit assignments to the "ret" variable to make it easier for gcc to verify that the code is actually correct, without the need to add a bogus initialization. Signed-off-by: Arnd Bergmann <arnd@...> Acked-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- drivers/cpufreq/cpufreq-dt.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 9bc37c437874a..0ca74d0700583 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -142,15 +142,16 @@ static int allocate_resources(int cpu, struct devic= e **cdev, =20 try_again: cpu_reg =3D regulator_get_optional(cpu_dev, reg); - if (IS_ERR(cpu_reg)) { + ret =3D PTR_ERR_OR_ZERO(cpu_reg); + if (ret) { /* * If cpu's regulator supply node is present, but regulator is * not yet registered, we should try defering probe. */ - if (PTR_ERR(cpu_reg) =3D=3D -EPROBE_DEFER) { + if (ret =3D=3D -EPROBE_DEFER) { dev_dbg(cpu_dev, "cpu%d regulator not ready, retry\n", cpu); - return -EPROBE_DEFER; + return ret; } =20 /* Try with "cpu-supply" */ @@ -159,18 +160,16 @@ try_again: goto try_again; } =20 - dev_dbg(cpu_dev, "no regulator for cpu%d: %ld\n", - cpu, PTR_ERR(cpu_reg)); + dev_dbg(cpu_dev, "no regulator for cpu%d: %d\n", cpu, ret); } =20 cpu_clk =3D clk_get(cpu_dev, NULL); - if (IS_ERR(cpu_clk)) { + ret =3D PTR_ERR_OR_ZERO(cpu_clk); + if (ret) { /* put regulator */ if (!IS_ERR(cpu_reg)) regulator_put(cpu_reg); =20 - ret =3D PTR_ERR(cpu_clk); - /* * If cpu's clk node is present, but clock is not yet * registered, we should try defering probe. --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 11/15] PM / OPP: Use snprintf() instead of sprintf()
Chen-Yu Tsai (Moxa) <wens@...>
From: Viresh Kumar <viresh.kumar@...>
commit 5ff24d601092b222340b28466e263b1c4559407e upstream. sprintf() can access memory outside of the range of the character array, and is risky in some situations. The driver specified prop_name string can be longer than NAME_MAX here (only an attacker will do that though) and so blindly copying it into the character array of size NAME_MAX isn't safe. Instead we must use snprintf() here. Reported-by: Geert Uytterhoeven <geert@...> Signed-off-by: Viresh Kumar <viresh.kumar@...> Acked-by: Geert Uytterhoeven <geert+renesas@...> Acked-by: Stephen Boyd <sboyd@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- drivers/base/power/opp/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.= c index 504a6d4e46723..1e0a2ddf73323 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -808,7 +808,8 @@ static int opp_parse_supplies(struct dev_pm_opp *opp,= struct device *dev, =20 /* Search for "opp-microvolt-<name>" */ if (dev_opp->prop_name) { - sprintf(name, "opp-microvolt-%s", dev_opp->prop_name); + snprintf(name, sizeof(name), "opp-microvolt-%s", + dev_opp->prop_name); prop =3D of_find_property(opp->np, name, NULL); } =20 @@ -855,7 +856,8 @@ static int opp_parse_supplies(struct dev_pm_opp *opp,= struct device *dev, /* Search for "opp-microamp-<name>" */ prop =3D NULL; if (dev_opp->prop_name) { - sprintf(name, "opp-microamp-%s", dev_opp->prop_name); + snprintf(name, sizeof(name), "opp-microamp-%s", + dev_opp->prop_name); prop =3D of_find_property(opp->np, name, NULL); } =20 --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 06/15] PM / OPP: Add missing doc comments
Chen-Yu Tsai (Moxa) <wens@...>
From: Viresh Kumar <viresh.kumar@...>
commit dc4e7b1fa20a840d2317fcfdaa1064fc09d2afcb upstream. Few doc-style comments were missing, add them. Rearrange another one to match the sequence within the structure. Signed-off-by: Viresh Kumar <viresh.kumar@...> Acked-by: Pavel Machek <pavel@...> Reviewed-by: Stephen Boyd <sboyd@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- drivers/base/power/opp/opp.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/opp/opp.h b/drivers/base/power/opp/opp.h index a6bd8d2c2b47f..b8880c7f8be1c 100644 --- a/drivers/base/power/opp/opp.h +++ b/drivers/base/power/opp/opp.h @@ -51,8 +51,8 @@ extern struct mutex dev_opp_list_lock; * are protected by the dev_opp_list_lock for integrity. * IMPORTANT: the opp nodes should be maintained in increasing * order. - * @dynamic: not-created from static DT entries. * @available: true/false - marks if this OPP as available or not + * @dynamic: not-created from static DT entries. * @turbo: true if turbo (boost) OPP * @suspend: true if suspend OPP * @rate: Frequency in hertz @@ -126,7 +126,9 @@ struct device_list_opp { * @dev_list: list of devices that share these OPPs * @opp_list: list of opps * @np: struct device_node pointer for opp's DT node. + * @clock_latency_ns_max: Max clock latency in nanoseconds. * @shared_opp: OPP is shared between multiple devices. + * @suspend_opp: Pointer to OPP to be used during device suspend. * @dentry: debugfs dentry pointer of the real device directory (not lin= ks). * @dentry_name: Name of the real dentry. * --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 09/15] PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties
Chen-Yu Tsai (Moxa) <wens@...>
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...>
commit fd8d8e63467c922be9ae4452cca2980d473477d9 upstream. Commit 01fb4d3c39d3 ("PM / OPP: Parse 'opp-<prop>-<name>' bindings") broke support for parsing standard opp-microvolt and opp-microamp properties. Fix it by setting 'name' string to proper value for !prop cases. Fixes: 01fb4d3c39d3 ("PM / OPP: Parse 'opp-<prop>-<name> 'bindings") Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...> Acked-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- drivers/base/power/opp/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.= c index 408fee4cb72df..504a6d4e46723 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -814,7 +814,7 @@ static int opp_parse_supplies(struct dev_pm_opp *opp,= struct device *dev, =20 if (!prop) { /* Search for "opp-microvolt" */ - name[13] =3D '\0'; + sprintf(name, "opp-microvolt"); prop =3D of_find_property(opp->np, name, NULL); =20 /* Missing property isn't a problem, but an invalid entry is */ @@ -861,7 +861,7 @@ static int opp_parse_supplies(struct dev_pm_opp *opp,= struct device *dev, =20 if (!prop) { /* Search for "opp-microamp" */ - name[12] =3D '\0'; + sprintf(name, "opp-microamp"); prop =3D of_find_property(opp->np, name, NULL); } =20 --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 05/15] PM / OPP: Rename OPP nodes as opp@<opp-hz>
Chen-Yu Tsai (Moxa) <wens@...>
From: Viresh Kumar <viresh.kumar@...>
commit 754dcf35f34698661801ae1d391efa02affe83a7 upstream. It would be better to name OPP nodes as opp@<opp-hz> as that will ensure that multiple DT nodes don't contain the same frequency. Of course we expect the writer to name the node with its opp-hz frequency and not any other frequency. And that will let the compile error out if multiple nodes are using the same opp-hz frequency. Suggested-by: Stephen Boyd <sboyd@...> Reviewed-by: Stephen Boyd <sboyd@...> Acked-by: Rob Herring <robh@...> Signed-off-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- Documentation/devicetree/bindings/opp/opp.txt | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentatio= n/devicetree/bindings/opp/opp.txt index 24eac9a977494..601256fe8c0dd 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -177,20 +177,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, = switch DVFS states together. compatible =3D "operating-points-v2"; opp-shared; =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000 975000 985000>; opp-microamp =3D <70000>; clock-latency-ns =3D <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz =3D /bits/ 64 <1100000000>; opp-microvolt =3D <980000 1000000 1010000>; opp-microamp =3D <80000>; clock-latency-ns =3D <310000>; }; - opp02 { + opp@1200000000 { opp-hz =3D /bits/ 64 <1200000000>; opp-microvolt =3D <1025000>; clock-latency-ns =3D <290000>; @@ -256,20 +256,20 @@ independently. * independently. */ =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000 975000 985000>; opp-microamp =3D <70000>; clock-latency-ns =3D <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz =3D /bits/ 64 <1100000000>; opp-microvolt =3D <980000 1000000 1010000>; opp-microamp =3D <80000>; clock-latency-ns =3D <310000>; }; - opp02 { + opp@1200000000 { opp-hz =3D /bits/ 64 <1200000000>; opp-microvolt =3D <1025000>; opp-microamp =3D <90000; @@ -332,20 +332,20 @@ DVFS state together. compatible =3D "operating-points-v2"; opp-shared; =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000 975000 985000>; opp-microamp =3D <70000>; clock-latency-ns =3D <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz =3D /bits/ 64 <1100000000>; opp-microvolt =3D <980000 1000000 1010000>; opp-microamp =3D <80000>; clock-latency-ns =3D <310000>; }; - opp02 { + opp@1200000000 { opp-hz =3D /bits/ 64 <1200000000>; opp-microvolt =3D <1025000>; opp-microamp =3D <90000>; @@ -358,20 +358,20 @@ DVFS state together. compatible =3D "operating-points-v2"; opp-shared; =20 - opp10 { + opp@1300000000 { opp-hz =3D /bits/ 64 <1300000000>; opp-microvolt =3D <1045000 1050000 1055000>; opp-microamp =3D <95000>; clock-latency-ns =3D <400000>; opp-suspend; }; - opp11 { + opp@1400000000 { opp-hz =3D /bits/ 64 <1400000000>; opp-microvolt =3D <1075000>; opp-microamp =3D <100000>; clock-latency-ns =3D <400000>; }; - opp12 { + opp@1500000000 { opp-hz =3D /bits/ 64 <1500000000>; opp-microvolt =3D <1010000 1100000 1110000>; opp-microamp =3D <95000>; @@ -398,7 +398,7 @@ Example 4: Handling multiple regulators compatible =3D "operating-points-v2"; opp-shared; =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000>, /* Supply 0 */ <960000>, /* Supply 1 */ @@ -411,7 +411,7 @@ Example 4: Handling multiple regulators =20 /* OR */ =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ @@ -424,7 +424,7 @@ Example 4: Handling multiple regulators =20 /* OR */ =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt =3D <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ @@ -456,7 +456,7 @@ Example 5: opp-supported-hw status =3D "okay"; opp-shared; =20 - opp00 { + opp@600000000 { /* * Supports all substrate and process versions for 0xF * cuts, i.e. only first four cuts. @@ -467,7 +467,7 @@ Example 5: opp-supported-hw ... }; =20 - opp01 { + opp@800000000 { /* * Supports: * - cuts: only one, 6th cut (represented by 6th bit). @@ -499,7 +499,7 @@ Example 6: opp-microvolt-<name>, opp-microamp-<name>: compatible =3D "operating-points-v2"; opp-shared; =20 - opp00 { + opp@1000000000 { opp-hz =3D /bits/ 64 <1000000000>; opp-microvolt-slow =3D <900000 915000 925000>; opp-microvolt-fast =3D <970000 975000 985000>; @@ -507,7 +507,7 @@ Example 6: opp-microvolt-<name>, opp-microamp-<name>: opp-microamp-fast =3D <71000>; }; =20 - opp01 { + opp@1200000000 { opp-hz =3D /bits/ 64 <1200000000>; opp-microvolt-slow =3D <900000 915000 925000>, /* Supply vcc0 */ <910000 925000 935000>; /* Supply vcc1 */ --=20 2.27.0.rc0
|
|
|
|
[4.4.y-cip 04/15] PM / OPP: Remove 'operating-points-names' binding
Chen-Yu Tsai (Moxa) <wens@...>
From: Viresh Kumar <viresh.kumar@...>
commit af87a39a5f7cf6ef252b1aec3e2e6508a40e51f1 upstream. These aren't used until now by any DT files and wouldn't be used now as we have a better scheme in place now, i.e. opp-property-<name> properties. Remove the (useless) binding without breaking ABI. Reviewed-by: Stephen Boyd <sboyd@...> Acked-by: Rob Herring <robh@...> Signed-off-by: Viresh Kumar <viresh.kumar@...> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...> Signed-off-by: Chen-Yu Tsai (Moxa) <wens@...> --- Documentation/devicetree/bindings/opp/opp.txt | 62 +------------------ 1 file changed, 2 insertions(+), 60 deletions(-) diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentatio= n/devicetree/bindings/opp/opp.txt index a3e7f0d5e1fb4..24eac9a977494 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -45,21 +45,10 @@ Devices supporting OPPs must set their "operating-poi= nts-v2" property with phandle to a OPP table in their DT node. The OPP core will use this phan= dle to find the operating points for the device. =20 -Devices may want to choose OPP tables at runtime and so can provide a li= st of -phandles here. But only *one* of them should be chosen at runtime. This = must be -accompanied by a corresponding "operating-points-names" property, to uni= quely -identify the OPP tables. - If required, this can be extended for SoC vendor specfic bindings. Such = bindings should be documented as Documentation/devicetree/bindings/power/<vendor>= -opp.txt and should have a compatible description like: "operating-points-v2-<ven= dor>". =20 -Optional properties: -- operating-points-names: Names of OPP tables (required if multiple OPP - tables are present), to uniquely identify them. The same list must be = present - for all the CPUs which are sharing clock/voltage rails and hence the O= PP - tables. - * OPP Table Node =20 This describes the OPPs belonging to a device. This node can have follow= ing @@ -448,54 +437,7 @@ Example 4: Handling multiple regulators }; }; =20 -Example 5: Multiple OPP tables - -/ { - cpus { - cpu@0 { - compatible =3D "arm,cortex-a7"; - ... - - cpu-supply =3D <&cpu_supply> - operating-points-v2 =3D <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast= ;- operating-points-names =3D "slow", "fast"; - }; - }; - - cpu0_opp_table_slow: opp_table_slow { - compatible =3D "operating-points-v2"; - status =3D "okay"; - opp-shared; - - opp00 { - opp-hz =3D /bits/ 64 <600000000>; - ... - }; - - opp01 { - opp-hz =3D /bits/ 64 <800000000>; - ... - }; - }; - - cpu0_opp_table_fast: opp_table_fast { - compatible =3D "operating-points-v2"; - status =3D "okay"; - opp-shared; - - opp10 { - opp-hz =3D /bits/ 64 <1000000000>; - ... - }; - - opp11 { - opp-hz =3D /bits/ 64 <1100000000>; - ... - }; - }; -}; - -Example 6: opp-supported-hw +Example 5: opp-supported-hw (example: three level hierarchy of versions: cuts, substrate and process= ) =20 / { @@ -540,7 +482,7 @@ Example 6: opp-supported-hw }; }; =20 -Example 7: opp-microvolt-<name>, opp-microamp-<name>: +Example 6: opp-microvolt-<name>, opp-microamp-<name>: (example: device with two possible microvolt ranges: slow and fast) =20 / { --=20 2.27.0.rc0
|
|
|
|
Re: [PATCH v2 v4.4.y-cip] ARM: dts: iwg20d-q7-common: Add LCD support
Pavel Machek
Hi!
The iwg20d comes with a 7" capacitive touch screen, thereforeThanks, applied, I'll run tests on it and push the result. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 08/15] PM / OPP: Parse 'opp-<prop>-<name>' bindings
Chen-Yu Tsai (Moxa) <wens@...>
On Thu, Jun 4, 2020 at 5:03 PM Pavel Machek <pavel@...> wrote:
That is a good argument. I suppose we just need to make sure the end result records both upstream commits, and that all of our automated tools can handle that. ChenYu
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 08/15] PM / OPP: Parse 'opp-<prop>-<name>' bindings
Pavel Machek
Hi!
This is fixed in the next patch. But I wonder if we should merge them/* TODO: Support multiple regulators */If in !dev_opp->prop_name, it will pass uninitialized buffer to into one for -cip... Unlike mainline, we already know about the bug. No need to prepare trap for people doing bisect. Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 03/15] PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
Chen-Yu Tsai (Moxa) <wens@...>
On Thu, Jun 4, 2020 at 4:46 PM Pavel Machek <pavel@...> wrote:
The new bindings format can take regex for node names and property names, so that itself shouldn't be an issue. The name itself is likely hardware specific so there's not much the automatic checker can do either. ChenYu Best regards,
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 08/15] PM / OPP: Parse 'opp-<prop>-<name>' bindings
Pavel Machek
Hi!
This is not right. /* TODO: Support multiple regulators */If in !dev_opp->prop_name, it will pass uninitialized buffer to of_find_property. Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 03/15] PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
Pavel Machek
Hi!
From: Viresh Kumar <viresh.kumar@...>That's really quite "interesting" design. I wondered if devicetree people are okay with that. If the name string isn't provided by the platform, or if it is providedBut, interestingly, their review tag is missing...? As this is mainline, I don't think we need to do anything here. I wonder how this kind of "wildcard" property names will play with new yml format or automatic device tree checks. Best regards, Pavel +++ b/Documentation/devicetree/bindings/opp/opp.txt-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
|
|
|
|
Re: [PATCH v2 v4.4.y-cip] ARM: dts: iwg20d-q7-common: Add LCD support
Pavel Machek
Hi!
I don't see anything wrong, either.The iwg20d comes with a 7" capacitive touch screen, thereforeLooks good to me this patch. SIMPLE_PANEL is not enabled in 4.4.y-cip/arm/renesas_shmobile_defconfig , and it seems to be driver relevant to this panel. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|
|
|
|
Re: CIP IRC weekly meeting today
masashi.kudo@cybertrust.co.jp <masashi.kudo@...>
Hi, Suzuki-san,
toggle quoted messageShow quoted text
Noted. See you next week. Best regards, -- M. Kudo
-----Original Message-----
From: akihiro27.suzuki@... <akihiro27.suzuki@...> Sent: Thursday, June 4, 2020 3:58 PM To: 工藤 雅司（CTJ OSS事業推進室） <masashi.kudo@...> Cc: cip-dev@... Subject: RE: CIP IRC weekly meeting today Hi Kudo-san, Sorry, I got a plan today. So I'll be absent today's IRC meeting. SW Updates WG doesn't have any updates since last week. Best regards, Suzuki -----Original Message----- From: cip-dev@... <cip-dev@...> On Behalf Of masashi.kudo@... Sent: Thursday, June 4, 2020 11:39 AM To: cip-dev@... Subject: [cip-dev] CIP IRC weekly meeting today Hi all, Kindly be reminded to attend the weekly meeting through IRC to discuss technical topics with CIP kernel today. *Please note that the IRC meeting was rescheduled to UTC (GMT) 09:00 starting from the first week of Apr. according to TSC meeting* https://www.timeanddate.com/worldclock/meetingdetails.html?year=2020&month=6&day=4&hour=9&min=0&sec=0&p1=224&p2=179&p3=136&p4=37&p5=241&p6=248 USWest USEast UK DE TW JP 02:00 05:00 10:00 11:00 17:00 18:00 Channel: * irc:chat.freenode.net:6667/cip Last meeting minutes: https://irclogs.baserock.org/meetings/cip/2020/05/cip.2020-05-28-09.00.log.html Agenda: * Action item 1. Combine root filesystem with kselftest binary - iwamatsu 2. Strengthen sustainable process to backport patches from Mainline/LTS - Kernel Team 3. Upload a guideline for reference hardware platform addition - masashi910 4. Post LTP results to KernelCI - patersonc 5. Ask board owners to review reference platform configs to optimize backporting - masashi910 6. Check CVE and Patch: NFS client (CVE-2020-10742) - Pavel-san 7. Check CVE and Patch, Bluetooth BAIS attack (CVE-2020-10135) - Iwamatsu-san * Kernel maintenance updates * Kernel testing * Software update * CIP Security * AOB The meeting will take 30 min, although it can be extended to an hour if it makes sense and those involved in the topics can stay. Otherwise, the topic will be taken offline or in the next meeting. Best regards, -- M. Kudo Cybertrust Japan Co., Ltd.
|
|
|
|
Re: CIP IRC weekly meeting today
Akihiro Suzuki
Hi Kudo-san,
toggle quoted messageShow quoted text
Sorry, I got a plan today. So I'll be absent today's IRC meeting. SW Updates WG doesn't have any updates since last week. Best regards, Suzuki
-----Original Message-----
From: cip-dev@... <cip-dev@...> On Behalf Of masashi.kudo@... Sent: Thursday, June 4, 2020 11:39 AM To: cip-dev@... Subject: [cip-dev] CIP IRC weekly meeting today Hi all, Kindly be reminded to attend the weekly meeting through IRC to discuss technical topics with CIP kernel today. *Please note that the IRC meeting was rescheduled to UTC (GMT) 09:00 starting from the first week of Apr. according to TSC meeting* https://www.timeanddate.com/worldclock/meetingdetails.html?year=2020&month=6&day=4&hour=9&min=0&sec=0&p1=224&p2=179&p3=136&p4=37&p5=241&p6=248 USWest USEast UK DE TW JP 02:00 05:00 10:00 11:00 17:00 18:00 Channel: * irc:chat.freenode.net:6667/cip Last meeting minutes: https://irclogs.baserock.org/meetings/cip/2020/05/cip.2020-05-28-09.00.log.html Agenda: * Action item 1. Combine root filesystem with kselftest binary - iwamatsu 2. Strengthen sustainable process to backport patches from Mainline/LTS - Kernel Team 3. Upload a guideline for reference hardware platform addition - masashi910 4. Post LTP results to KernelCI - patersonc 5. Ask board owners to review reference platform configs to optimize backporting - masashi910 6. Check CVE and Patch: NFS client (CVE-2020-10742) - Pavel-san 7. Check CVE and Patch, Bluetooth BAIS attack (CVE-2020-10135) - Iwamatsu-san * Kernel maintenance updates * Kernel testing * Software update * CIP Security * AOB The meeting will take 30 min, although it can be extended to an hour if it makes sense and those involved in the topics can stay. Otherwise, the topic will be taken offline or in the next meeting. Best regards, -- M. Kudo Cybertrust Japan Co., Ltd.
|
|
|
|
Re: [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1
Nobuhiro Iwamatsu
Hi Wens,
toggle quoted messageShow quoted text
Thanks for your patch!
-----Original Message-----I have nothing to point out other than the comment on "PM / OPP: Set cpu_dev->id in cpumask first". Best regards, Nobuhiro
|
|
|