|
Re: [PATCH 4.19.y-cip 0/6] Add RTC support
Thanks for the series, applied, and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
Thanks for the series, applied, and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
|
By
Pavel Machek
·
#2713
·
|
|
Re: [PATCH 4.19.y-cip 2/6] arm64: dts: renesas: r8a774c0-cat874: Add RWDT support
So this will reboot machine if userspace does not ping it within 60
seconds by default?
Will that break user configurations that worked up till now, but do
not contain watchdog support?
Do we
So this will reboot machine if userspace does not ping it within 60
seconds by default?
Will that break user configurations that worked up till now, but do
not contain watchdog support?
Do we
|
By
Pavel Machek
·
#2712
·
|
|
Re: [PATCH 4.19.y-cip 1/6] arm64: dts: renesas: r8a774c0-cat874: Add LEDs support
Hi!
With my LED maintainer hat on... these are not exactly useful LED
names. Do they have any fixed meaning? Are they labeled on the board?
What color are they?
Best regards,
Pavel
--
DENX
Hi!
With my LED maintainer hat on... these are not exactly useful LED
names. Do they have any fixed meaning? Are they labeled on the board?
What color are they?
Best regards,
Pavel
--
DENX
|
By
Pavel Machek
·
#2711
·
|
|
Re: [PATCH 4.19.y-cip 4/6] rtc: rx8581: Add support for Epson rx8571 RTC
Hi!
I see that 85x1 has single byte of RAM. I'd still expect return of
error in case of offset != 0 or bytes != 1.
Probably best done in mainline first...
Best regards,
Pavel
--
DENX
Hi!
I see that 85x1 has single byte of RAM. I'd still expect return of
error in case of offset != 0 or bytes != 1.
Probably best done in mainline first...
Best regards,
Pavel
--
DENX
|
By
Pavel Machek
·
#2710
·
|
|
Re: [ANNOUNCE] 4.4.176-cip31-rt23
Hi!
Thanks for good news. You have privat CI system, right?
If sources are available somewhere, I can try to help with testing.
Best regards,
Pavl
--
DENX Software Engineering GmbH,
Hi!
Thanks for good news. You have privat CI system, right?
If sources are available somewhere, I can try to help with testing.
Best regards,
Pavl
--
DENX Software Engineering GmbH,
|
By
Pavel Machek
·
#2709
·
|
|
Re: [PATCH 4.4.y-cip 0/5] Add QSPI support
Hi!
Applied, and pushed out.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
Hi!
Applied, and pushed out.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
|
By
Pavel Machek
·
#2708
·
|
|
Re: [PATCH 4.19.y-cip 00/12] Add USB Host support
Hi!
I'll note that english in comment in 11/12 could use some improvement,
too.
Thanks, applied, and I'll push it out soon.
Best regards,
Pavel
--
(english)
Hi!
I'll note that english in comment in 11/12 could use some improvement,
too.
Thanks, applied, and I'll push it out soon.
Best regards,
Pavel
--
(english)
|
By
Pavel Machek
·
#2707
·
|
|
Re: [ANNOUNCE] 4.4.176-cip31-rt23
FWIW, I am updating the stable-rt tree right now. As noted there are a couple of merge conflicts ahead. Right now I am testing the result of the v4.4.180 merge. So far all looks good and now I am
FWIW, I am updating the stable-rt tree right now. As noted there are a couple of merge conflicts ahead. Right now I am testing the result of the v4.4.180 merge. So far all looks good and now I am
|
By
Daniel Wagner <wagi@...>
·
#2706
·
|
|
Re: [PATCH 4.19.y-cip 04/12] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling
Hi Pavel,
Thanks for the feedback.
Hi Pavel,
Thanks for the feedback.
|
By
Biju Das <biju.das@...>
·
#2705
·
|
|
Re: [PATCH 4.19.y-cip 05/12] phy: renesas: rcar-gen3-usb2: add conditions for uses_otg_pins == false
HI Pavel,
Thanks for the feedback.
HI Pavel,
Thanks for the feedback.
|
By
Biju Das <biju.das@...>
·
#2704
·
|
|
Re: [PATCH 4.19.y-cip 08/12] phy: renesas: rcar-gen3-usb2: follow the hardware manual procedure
Hi Pavel,
Thanks for the feedback.
As mentioned in the commit message, "procedure to follow Figure
73.4 of "R-Car Series, 3rd Generation User's Manual: Hardware Rev.1.00".
The hardware manual
Hi Pavel,
Thanks for the feedback.
As mentioned in the commit message, "procedure to follow Figure
73.4 of "R-Car Series, 3rd Generation User's Manual: Hardware Rev.1.00".
The hardware manual
|
By
Biju Das <biju.das@...>
·
#2703
·
|
|
Re: [PATCH 4.19.y-cip 08/12] phy: renesas: rcar-gen3-usb2: follow the hardware manual procedure
Hi!
I don't understand the comment here. Actually having function to
set/clear bits in arbitrary register might be a nice cleanup.
While reviewing that I noticed:
static void
Hi!
I don't understand the comment here. Actually having function to
set/clear bits in arbitrary register might be a nice cleanup.
While reviewing that I noticed:
static void
|
By
Pavel Machek
·
#2702
·
|
|
Re: [PATCH 4.19.y-cip 05/12] phy: renesas: rcar-gen3-usb2: add conditions for uses_otg_pins == false
Hi!
I'd write this as
"return ch->dr_mode != USB_DR_MODE_HOST;"
I'll take the patch, anyway, but there's room for future cleanup.
Best regards,
Pavel
--
(english)
Hi!
I'd write this as
"return ch->dr_mode != USB_DR_MODE_HOST;"
I'll take the patch, anyway, but there's room for future cleanup.
Best regards,
Pavel
--
(english)
|
By
Pavel Machek
·
#2701
·
|
|
Re: [PATCH 4.19.y-cip 04/12] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling
Hi!
This actually removes optimalization: old code would avoid
reading USB2_OBINTEN twice. I guess it is not a problem.
Best regards,
Pavel
--
(english)
Hi!
This actually removes optimalization: old code would avoid
reading USB2_OBINTEN twice. I guess it is not a problem.
Best regards,
Pavel
--
(english)
|
By
Pavel Machek
·
#2700
·
|
|
Re: [PATCH 4.19.y-cip 15/23] clk: renesas: rcar-gen3: Support Z and Z2 clocks with high frequency parents
Hi Pavel,
Thanks for the feedback.
Gen3 SoC's are aarch64. So I think it is ok.
Regards,
Biju
Hi Pavel,
Thanks for the feedback.
Gen3 SoC's are aarch64. So I think it is ok.
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#2699
·
|
|
Re: [PATCH 4.19.y-cip 21/23] clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value
Hi Pavel,
Thanks for the feedback.
Yes, I agree with you. It is too late to fix it.
Regards,
Biju
Hi Pavel,
Thanks for the feedback.
Yes, I agree with you. It is too late to fix it.
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#2698
·
|
|
Re: [PATCH 4.19.y-cip 0/4] Add CAN support
Thanks; applied and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Thanks; applied and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|
By
Pavel Machek
·
#2697
·
|
|
Re: [PATCH 4.19.y-cip 00/23] Clock enhancements
Hi!
Thanks. Applied and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
Hi!
Thanks. Applied and pushed out.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
|
By
Pavel Machek
·
#2696
·
|
|
Re: [PATCH 4.19.y-cip 21/23] clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value
Hi!
This is not quite correct english, but I guess it is too late to fix
that.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
Hi!
This is not quite correct english, but I guess it is too late to fix
that.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
|
By
Pavel Machek
·
#2695
·
|
|
Re: [PATCH 4.19.y-cip 15/23] clk: renesas: rcar-gen3: Support Z and Z2 clocks with high frequency parents
Hi!
You still store "parent_rate" in "unsigned long". That is going to
overflow on 32-bit systems, right?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky,
Hi!
You still store "parent_rate" in "unsigned long". That is going to
overflow on 32-bit systems, right?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky,
|
By
Pavel Machek
·
#2694
·
|