|
|
Re: [PATCH 4.19.y-cip 30/57] ASoC: rsnd: add SSIU BUSIF support
HI Pavel,
Thanks for the feedback.
I think, it is talking about "Old" means BUS IF handled by SSI driver and "New" means BUSIF handled by SSIU.
If you have new DT style and don't have this driver
|
HI Pavel,
Thanks for the feedback.
I think, it is talking about "Old" means BUS IF handled by SSI driver and "New" means BUSIF handled by SSIU.
If you have new DT style and don't have this driver
|
By
Biju Das <biju.das@...>
·
#3538
·
|
|
Re: [PATCH 4.19.y-cip 25/57] ASoC: rsnd: remove endpoint bidirectional check
+ Morimoto San,
Hi Pavel, Thanks for the feedback.
This patch is overridden by " 0028-ASoC-rsnd-move-HDMI-information-from-ssi.c-to-core.c.patch", yes I agree we are still missing
|
+ Morimoto San,
Hi Pavel, Thanks for the feedback.
This patch is overridden by " 0028-ASoC-rsnd-move-HDMI-information-from-ssi.c-to-core.c.patch", yes I agree we are still missing
|
By
Biju Das <biju.das@...>
·
#3537
·
|
|
Re: [PATCH 4.19.y-cip 24/57] ASoC: rsnd: rsnd_mod_name() handles both name and ID
Hi Pavel,
Thanks for the feedback.
Can you please elaborate more on the dangerous interface ?
Can you please suggest the correct way of doing this?
Cheers,
Biju
|
Hi Pavel,
Thanks for the feedback.
Can you please elaborate more on the dangerous interface ?
Can you please suggest the correct way of doing this?
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3536
·
|
|
Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro
+ Morimoto-San,
Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
+ Morimoto-San,
Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3535
·
|
|
Re: [PATCH 4.19.y-cip 15/57] ASoC: convert for_each_rtd_codec_dai() for missing part
+ Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
+ Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3534
·
|
|
Re: [PATCH 4.19.y-cip 14/57] ASoC: add for_each_rtd_codec_dai() macro
HI Pavel,
Thanks for the feedback
I have backported this patch only because I got compilation error.
Regards,
Biju
|
HI Pavel,
Thanks for the feedback
I have backported this patch only because I got compilation error.
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3533
·
|
|
Re: [PATCH 4.19.y-cip 13/57] ASoC: rsnd: don't use %p for dev_dbg()
Hi Pave,
Thanks for the feedback.
Yes, for production scenario no one will enable this.
Regards,
Biju
|
Hi Pave,
Thanks for the feedback.
Yes, for production scenario no one will enable this.
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3532
·
|
|
Re: [PATCH 4.19.y-cip 12/57] ASoC: rsnd: gen: use tab instead of white-space
Hi Pavel,
Thanks for the feedback.
Later patches touches in this area. That is the reason.
Cheers,
Biju
|
Hi Pavel,
Thanks for the feedback.
Later patches touches in this area. That is the reason.
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3531
·
|
|
Re: [PATCH 4.19.y-cip 06/57] ASoC: rsnd: ssi: Check runtime channel number rather than hw_params
Hi Pavel,
Thanks for the feedback.
Do you prefer -EIO rather than -EINVAL? For me, -EINVAL make sense here.
Cheers,
Biju
|
Hi Pavel,
Thanks for the feedback.
Do you prefer -EIO rather than -EINVAL? For me, -EINVAL make sense here.
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3530
·
|
|
Re: [PATCH 4.19.y-cip 0/6] Add HDMI AUDIO/CAN/CANFD support
Hi Pavel,
Thanks for the review
Cheers,
Biju
|
Hi Pavel,
Thanks for the review
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3529
·
|
|
Re: [PATCH 4.19.y-cip 3/6] dt-bindings: can: rcar_canfd: document r8a774a1 support
Hi Pavel,
Thanks for the feedback.
Good Catch. Yes this to be fixed it in the Upstream first.
Cheers,
Biju
|
Hi Pavel,
Thanks for the feedback.
Good Catch. Yes this to be fixed it in the Upstream first.
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3528
·
|
|
Re: [PATCH 4.19.y-cip 32/57] ASoC: rsnd: use ring buffer for rsnd_mod_name()
I'd really preffer caller passing pointer to buffer to be used to the
function.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235
|
I'd really preffer caller passing pointer to buffer to be used to the
function.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235
|
By
Pavel Machek
·
#3527
·
|
|
Re: [PATCH 4.19.y-cip 30/57] ASoC: rsnd: add SSIU BUSIF support
Hi!
I'm not sure which Document this talks about:
Patch does not seem to be changing any documentation.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director:
|
Hi!
I'm not sure which Document this talks about:
Patch does not seem to be changing any documentation.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director:
|
By
Pavel Machek
·
#3526
·
|
|
Re: [PATCH 4.19.y-cip 28/57] ASoC: rsnd: move HDMI information from ssi.c to core.c
Hi!
Does it miss of_node_put()?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
|
Hi!
Does it miss of_node_put()?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
|
By
Pavel Machek
·
#3525
·
|
|
Re: [PATCH 4.19.y-cip 25/57] ASoC: rsnd: remove endpoint bidirectional check
Hi!
I don't really understand what bidirectional check? Are you saying
that of_graph_get_remote_endpoint() never fails in 4.19.X ?
Plus the code seems to be missing of_node_put().
Best
|
Hi!
I don't really understand what bidirectional check? Are you saying
that of_graph_get_remote_endpoint() never fails in 4.19.X ?
Plus the code seems to be missing of_node_put().
Best
|
By
Pavel Machek
·
#3524
·
|
|
Re: [PATCH 4.19.y-cip 24/57] ASoC: rsnd: rsnd_mod_name() handles both name and ID
Hi!
No, don't do that. That's a dangerous interface.
This is too hard to use correctly.
For example this usage is not correct.
And yes, I took a look at mainline, and no, having 5 static
|
Hi!
No, don't do that. That's a dangerous interface.
This is too hard to use correctly.
For example this usage is not correct.
And yes, I took a look at mainline, and no, having 5 static
|
By
Pavel Machek
·
#3523
·
|
|
Re: [PATCH 4.19.y-cip 19/57] ASoC: rsnd: use 32bit TDM width as default
I don't think I like this. People should not be passing strange values
to this function. Can the caller be fixed, instead?
Thanks,
Pavel
--
DENX Software Engineering GmbH, Managing
|
I don't think I like this. People should not be passing strange values
to this function. Can the caller be fixed, instead?
Thanks,
Pavel
--
DENX Software Engineering GmbH, Managing
|
By
Pavel Machek
·
#3522
·
|
|
Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro
Hi!
This macro is really confusing. dpcm is used as both control variable
of the loop and name of the field in *be. Plus it relies on list_fe
variable to be present in the context including it...
|
Hi!
This macro is really confusing. dpcm is used as both control variable
of the loop and name of the field in *be. Plus it relies on list_fe
variable to be present in the context including it...
|
By
Pavel Machek
·
#3521
·
|
|
Re: [PATCH 4.19.y-cip 15/57] ASoC: convert for_each_rtd_codec_dai() for missing part
Hi!
This conversion is not equivalent. Original code always goes through
num_codecs, new code stops at first NULL pointer. I assume there are
always non-NULL pointers in the list, but perhaps new
|
Hi!
This conversion is not equivalent. Original code always goes through
num_codecs, new code stops at first NULL pointer. I assume there are
always non-NULL pointers in the list, but perhaps new
|
By
Pavel Machek
·
#3520
·
|
|
Re: [PATCH 4.19.y-cip 14/57] ASoC: add for_each_rtd_codec_dai() macro
Hi!
I'm okay with for_each_rtd_codec_dai() macro. But there's _reverse
macro, and they look very, very similar, except that the _reverse
macro does not actually initialize i... Yes, code needs it
|
Hi!
I'm okay with for_each_rtd_codec_dai() macro. But there's _reverse
macro, and they look very, very similar, except that the _reverse
macro does not actually initialize i... Yes, code needs it
|
By
Pavel Machek
·
#3519
·
|
