|
Re: [PATCH 4.19.y-cip 39/57] ASoC: rsnd: remove RSND_REG_ from rsnd_reg
Hi!
Would it still make sense to test that i is in expected range?
#define CHECK_RANGE(i) ({ WARN_ON(i<0 || i>4); i; })
#define SRCIN_TIMSEL(i) (SRCIN_TIMSEL0 + (i))
...
Thanks and
Hi!
Would it still make sense to test that i is in expected range?
#define CHECK_RANGE(i) ({ WARN_ON(i<0 || i>4); i; })
#define SRCIN_TIMSEL(i) (SRCIN_TIMSEL0 + (i))
...
Thanks and
|
By
Pavel Machek
·
#3553
·
|
|
Re: [PATCH 4.19.y-cip 0/6] Add HDMI AUDIO/CAN/CANFD support
Hello Pavel,
Just to let you know, the arm64 boards are currently offline in the Renesas LAVA lab.
I'm working to get them online again, but the impact will be that your test jobs will eventually
Hello Pavel,
Just to let you know, the arm64 boards are currently offline in the Renesas LAVA lab.
I'm working to get them online again, but the impact will be that your test jobs will eventually
|
By
Chris Paterson
·
#3552
·
|
|
Re: [PATCH 4.19.y-cip 0/6] Add HDMI AUDIO/CAN/CANFD support
Hi!
I applied the patches. Tests are still running (
https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/91254170
) but I don't expect problems there.
Best regards,
Pavel
--
DENX
Hi!
I applied the patches. Tests are still running (
https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/91254170
) but I don't expect problems there.
Best regards,
Pavel
--
DENX
|
By
Pavel Machek
·
#3551
·
|
|
Re: CIP IRC weekly meeting today
Hi, SZ-san,
Yes, please close this AI. Thanks very much for your cooperation.
Best regards,
--
M. Kudo
Hi, SZ-san,
Yes, please close this AI. Thanks very much for your cooperation.
Best regards,
--
M. Kudo
|
By
masashi.kudo@...
·
#3550
·
|
|
Re: CIP IRC weekly meeting today
Hi Kudo-san,
Thanks for you heads up.
For now, we’re waiting for your patches. So I think we can close this AI if you have no objection.
SZ
Hi Kudo-san,
Thanks for you heads up.
For now, we’re waiting for your patches. So I think we can close this AI if you have no objection.
SZ
|
By
SZ Lin (林上智) <SZ.Lin@...>
·
#3549
·
|
|
Re: CIP IRC weekly meeting today
SZ-san,
> 3. Review the proposal from Kudo-san - Kernel team
I'm sorry, but I cannot attend today's meeting due to another appointment.
If I need to do anything, please let me know.
Best
SZ-san,
> 3. Review the proposal from Kudo-san - Kernel team
I'm sorry, but I cannot attend today's meeting due to another appointment.
If I need to do anything, please let me know.
Best
|
By
masashi.kudo@...
·
#3548
·
|
|
CIP IRC weekly meeting today
Hi all,
Kindly be reminded to attend the weekly meeting through IRC to discuss technical topics with CIP kernel today.
*Please note that the IRC meeting was rescheduled to UTC (GMT) 09:00
Hi all,
Kindly be reminded to attend the weekly meeting through IRC to discuss technical topics with CIP kernel today.
*Please note that the IRC meeting was rescheduled to UTC (GMT) 09:00
|
By
SZ Lin (林上智) <SZ.Lin@...>
·
#3547
·
|
|
Re: [PATCH 4.19.y-cip 15/57] ASoC: convert for_each_rtd_codec_dai() for missing part
Hello Morimota-San,
Thanks for the feedback.
This comments are from code review.
https://lists.cip-project.org/pipermail/cip-dev/2019-October/thread.html#3456
Cheers,
Biju
Hello Morimota-San,
Thanks for the feedback.
This comments are from code review.
https://lists.cip-project.org/pipermail/cip-dev/2019-October/thread.html#3456
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3546
·
|
|
Re: [PATCH 4.19.y-cip 19/57] ASoC: rsnd: use 32bit TDM width as default
Hi
As git-log said, it is default values, not strange value.
People don't set all settings, especially it was default.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Hi
As git-log said, it is default values, not strange value.
People don't set all settings, especially it was default.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
|
By
Kuninori Morimoto <kuninori.morimoto.gx@...>
·
#3545
·
|
|
Re: [PATCH 4.19.y-cip 25/57] ASoC: rsnd: remove endpoint bidirectional check
Hi
On OF-graph DT, remote-endpoint need to be pair.
ex)
endpoint1: endpoint {
remote-endpoint = <&endpoint2>;
};
endpoint2: endpoint {
remote-endpoint = <&endpoint1>;
};
This "bidirectional
Hi
On OF-graph DT, remote-endpoint need to be pair.
ex)
endpoint1: endpoint {
remote-endpoint = <&endpoint2>;
};
endpoint2: endpoint {
remote-endpoint = <&endpoint1>;
};
This "bidirectional
|
By
Kuninori Morimoto <kuninori.morimoto.gx@...>
·
#3544
·
|
|
Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro
Hi
Ohh, yes, indeed.
Thank you for pointing it. I will post fixup patch
sorry I couldn't understand about this
This "&" is for fe_clients
Thank you for your help !!
Best regards
---
Kuninori
Hi
Ohh, yes, indeed.
Thank you for pointing it. I will post fixup patch
sorry I couldn't understand about this
This "&" is for fe_clients
Thank you for your help !!
Best regards
---
Kuninori
|
By
Kuninori Morimoto <kuninori.morimoto.gx@...>
·
#3543
·
|
|
Re: [PATCH 4.19.y-cip 15/57] ASoC: convert for_each_rtd_codec_dai() for missing part
Hi
Hmm.. strange.
If original code goes through eventhough NULL pointer,
it will be Oops at dai->playback_widget access ?
? Does this comment came from code review,
instead of actual machine
Hi
Hmm.. strange.
If original code goes through eventhough NULL pointer,
it will be Oops at dai->playback_widget access ?
? Does this comment came from code review,
instead of actual machine
|
By
Kuninori Morimoto <kuninori.morimoto.gx@...>
·
#3542
·
|
|
Re: [PATCH 4.19.y-cip 19/57] ASoC: rsnd: use 32bit TDM width as default
+ Morimoto-San,
Hi Pavel,
Thanks for the feedback.
+ Morimoto-San,
Hi Pavel,
Thanks for the feedback.
|
By
Biju Das <biju.das@...>
·
#3541
·
|
|
Re: [PATCH 4.19.y-cip 32/57] ASoC: rsnd: use ring buffer for rsnd_mod_name()
+Morimoto-San,
By
Biju Das <biju.das@...>
·
#3540
·
|
|
Re: [PATCH 4.19.y-cip 28/57] ASoC: rsnd: move HDMI information from ssi.c to core.c
+ Morimoto-San
Hi Pavel,
Thanks for the feedback.
Ye looks like we are missing of_node_put. Morimoto-San any comments?
Regards,
Biju
+ Morimoto-San
Hi Pavel,
Thanks for the feedback.
Ye looks like we are missing of_node_put. Morimoto-San any comments?
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3539
·
|
|
Re: [PATCH 4.19.y-cip 30/57] ASoC: rsnd: add SSIU BUSIF support
HI Pavel,
Thanks for the feedback.
I think, it is talking about "Old" means BUS IF handled by SSI driver and "New" means BUSIF handled by SSIU.
If you have new DT style and don't have this driver
HI Pavel,
Thanks for the feedback.
I think, it is talking about "Old" means BUS IF handled by SSI driver and "New" means BUSIF handled by SSIU.
If you have new DT style and don't have this driver
|
By
Biju Das <biju.das@...>
·
#3538
·
|
|
Re: [PATCH 4.19.y-cip 25/57] ASoC: rsnd: remove endpoint bidirectional check
+ Morimoto San,
Hi Pavel, Thanks for the feedback.
This patch is overridden by " 0028-ASoC-rsnd-move-HDMI-information-from-ssi.c-to-core.c.patch", yes I agree we are still missing
+ Morimoto San,
Hi Pavel, Thanks for the feedback.
This patch is overridden by " 0028-ASoC-rsnd-move-HDMI-information-from-ssi.c-to-core.c.patch", yes I agree we are still missing
|
By
Biju Das <biju.das@...>
·
#3537
·
|
|
Re: [PATCH 4.19.y-cip 24/57] ASoC: rsnd: rsnd_mod_name() handles both name and ID
Hi Pavel,
Thanks for the feedback.
Can you please elaborate more on the dangerous interface ?
Can you please suggest the correct way of doing this?
Cheers,
Biju
Hi Pavel,
Thanks for the feedback.
Can you please elaborate more on the dangerous interface ?
Can you please suggest the correct way of doing this?
Cheers,
Biju
|
By
Biju Das <biju.das@...>
·
#3536
·
|
|
Re: [PATCH 4.19.y-cip 16/57] ASoC: add for_each_dpcm_fe() macro
+ Morimoto-San,
Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
+ Morimoto-San,
Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3535
·
|
|
Re: [PATCH 4.19.y-cip 15/57] ASoC: convert for_each_rtd_codec_dai() for missing part
+ Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
+ Morimoto-San,
Do you have any opinion on Pavel's findings?
Regards,
Biju
|
By
Biju Das <biju.das@...>
·
#3534
·
|