|
Re: [PATCH 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver
Hi Pavel,
Thank you for the review.
Hi Pavel,
Thank you for the review.
|
By
Lad Prabhakar
·
#5832
·
|
|
Re: [PATCH 4.19.y-cip 7/7] spi: add Renesas RPC-IF driver
Hi!
Few lines here explaining the acronyms etc. would be nice.
With just one user of the error exit, I'd avoid the goto.
Can you just add "__maybe_unused" annotation and avoid the ifdefs,
like
Hi!
Few lines here explaining the acronyms etc. would be nice.
With just one user of the error exit, I'd avoid the goto.
Can you just add "__maybe_unused" annotation and avoid the ifdefs,
like
|
By
Pavel Machek
·
#5831
·
|
|
Re: [PATCH 4.19.y-cip 6/7] spi: spi-mem: Add a new API to support direct mapping
Hi!
I'd do return ... here.
and here.
To help with if/else nesting. spi_mem_dirmap_write could use same
treatment.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing
Hi!
I'd do return ... here.
and here.
To help with if/else nesting. spi_mem_dirmap_write could use same
treatment.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing
|
By
Pavel Machek
·
#5830
·
|
|
Re: [PATCH 4.19.y-cip 5/7] spi: spi-mem: Split spi_mem_exec_op() code
Hi!
...
This misses pm_runtime_put() in the error case.
Plus hiding locking into function like this ... is quite
"interesting".
Best regards,
Pavel
--
DENX Software Engineering GmbH,
Hi!
...
This misses pm_runtime_put() in the error case.
Plus hiding locking into function like this ... is quite
"interesting".
Best regards,
Pavel
--
DENX Software Engineering GmbH,
|
By
Pavel Machek
·
#5829
·
|
|
Re: [PATCH 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver
Hi!
Oh and I'd use normal C comment here.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
Hi!
Oh and I'd use normal C comment here.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
|
By
Pavel Machek
·
#5828
·
|
|
Re: [PATCH 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver
Hi!
EXPORT_SYMBOL_GPL?
Should these go to header as static inlines?
This can't be right. sts is used uninitialized here.
So we get failure in wait_msg_xfer_end(rpc); but
Hi!
EXPORT_SYMBOL_GPL?
Should these go to header as static inlines?
This can't be right. sts is used uninitialized here.
So we get failure in wait_msg_xfer_end(rpc); but
|
By
Pavel Machek
·
#5827
·
|
|
A lot of compiles failing
Hi!
This is going on for a few days now, but today it seems worse than
usual:
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/220169843
builds are failing, 'HTTP 500 curl 22' error,
Hi!
This is going on for a few days now, but today it seems worse than
usual:
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/220169843
builds are failing, 'HTTP 500 curl 22' error,
|
By
Pavel Machek
·
#5826
·
|
|
Re: [PATCH 4.19.y-cip 0/2] Add sound support to R8A774E1 SoC
Hi!
I don't see any problems here. If there are no other comments, I can
apply it.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235
Hi!
I don't see any problems here. If there are no other comments, I can
apply it.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235
|
By
Pavel Machek
·
#5825
·
|
|
Re: [PATCH 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
Hi,
By
Lad Prabhakar
·
#5824
·
|
|
[PATCH 4.19.y-cip 7/7] spi: add Renesas RPC-IF driver
From: Sergei Shtylyov <sergei.shtylyov@...>
commit eb8d6d464a27850498dced21a8450e85d4a02009 upstream.
Add the SPI driver for the Renesas RPC-IF. It's the "front end" driver
using the
From: Sergei Shtylyov <sergei.shtylyov@...>
commit eb8d6d464a27850498dced21a8450e85d4a02009 upstream.
Add the SPI driver for the Renesas RPC-IF. It's the "front end" driver
using the
|
By
Lad Prabhakar
·
#5823
·
|
|
[PATCH 4.19.y-cip 6/7] spi: spi-mem: Add a new API to support direct mapping
From: Boris Brezillon <boris.brezillon@...>
commit aa167f3fed0c37e0e4c707d4331d827661f46644 upstream.
Most modern SPI controllers can directly map a SPI memory (or a portion
of the SPI
From: Boris Brezillon <boris.brezillon@...>
commit aa167f3fed0c37e0e4c707d4331d827661f46644 upstream.
Most modern SPI controllers can directly map a SPI memory (or a portion
of the SPI
|
By
Lad Prabhakar
·
#5822
·
|
|
[PATCH 4.19.y-cip 5/7] spi: spi-mem: Split spi_mem_exec_op() code
From: Boris Brezillon <boris.brezillon@...>
commit f86c24f4795303e4024bc113196de32782f6ccb5 upstream.
The logic surrounding the ->exec_op() call applies to direct mapping
accessors. Move
From: Boris Brezillon <boris.brezillon@...>
commit f86c24f4795303e4024bc113196de32782f6ccb5 upstream.
The logic surrounding the ->exec_op() call applies to direct mapping
accessors. Move
|
By
Lad Prabhakar
·
#5821
·
|
|
[PATCH 4.19.y-cip 4/7] spi: spi-mem: export spi_mem_default_supports_op()
From: Naga Sureshkumar Relli <naga.sureshkumar.relli@...>
commit 46109648052fe778c75f199d72255c899578d6f7 upstream.
Export spi_mem_default_supports_op(), so that controller drivers
can use
From: Naga Sureshkumar Relli <naga.sureshkumar.relli@...>
commit 46109648052fe778c75f199d72255c899578d6f7 upstream.
Export spi_mem_default_supports_op(), so that controller drivers
can use
|
By
Lad Prabhakar
·
#5820
·
|
|
[PATCH 4.19.y-cip 3/7] spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
From: Boris Brezillon <boris.brezillon@...>
commit 0ebb261a0b2d090de618a383d2378d4a00834958 upstream.
When defining spi_mem_op templates we don't necessarily know the size
that will be
From: Boris Brezillon <boris.brezillon@...>
commit 0ebb261a0b2d090de618a383d2378d4a00834958 upstream.
When defining spi_mem_op templates we don't necessarily know the size
that will be
|
By
Lad Prabhakar
·
#5819
·
|
|
[PATCH 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver
From: Sergei Shtylyov <sergei.shtylyov@...>
commit ca7d8b980b67f133317525c4273e144116ee1ae5 upstream.
Add the memory driver for Renesas RPC-IF which registers either SPI or
HyperFLash
From: Sergei Shtylyov <sergei.shtylyov@...>
commit ca7d8b980b67f133317525c4273e144116ee1ae5 upstream.
Add the memory driver for Renesas RPC-IF which registers either SPI or
HyperFLash
|
By
Lad Prabhakar
·
#5818
·
|
|
[PATCH 4.19.y-cip 1/7] dt-bindings: memory: document Renesas RPC-IF bindings
From: Sergei Shtylyov <sergei.shtylyov@...>
commit ab1c362061d92556bd96fd2c0b188f8e4223e3e3 upstream.
Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
HyperFlash
From: Sergei Shtylyov <sergei.shtylyov@...>
commit ab1c362061d92556bd96fd2c0b188f8e4223e3e3 upstream.
Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
HyperFlash
|
By
Lad Prabhakar
·
#5817
·
|
|
[PATCH 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
Hi Nobuhiro, Pavel,
This patch series adds SPI driver for the Renesas RPC-IF.
Alongside relevant changes for spi-mem have been also
backported. This enables accessing SPI flash chip connected
to
Hi Nobuhiro, Pavel,
This patch series adds SPI driver for the Renesas RPC-IF.
Alongside relevant changes for spi-mem have been also
backported. This enables accessing SPI flash chip connected
to
|
By
Lad Prabhakar
·
#5816
·
|
|
[PATCH 4.19.y-cip 2/2] arm64: dts: renesas: r8a774e1: Add audio support
commit 8183a7938cfec0569d77755af5ce5ff5589f3540 upstream.
Add sound support for the RZ/G2H SoC (a.k.a. R8A774E1).
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by:
commit 8183a7938cfec0569d77755af5ce5ff5589f3540 upstream.
Add sound support for the RZ/G2H SoC (a.k.a. R8A774E1).
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by:
|
By
Lad Prabhakar
·
#5815
·
|
|
[PATCH 4.19.y-cip 1/2] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
commit 7de8bfaa095fcbc2db2952d4b561be102a41c2a6 upstream.
Add audio_clk_b configured as 0 Hz, this will be overridden by the
boards providing the audio clock.
Fixes: 8183a7938cfec ("arm64: dts:
commit 7de8bfaa095fcbc2db2952d4b561be102a41c2a6 upstream.
Add audio_clk_b configured as 0 Hz, this will be overridden by the
boards providing the audio clock.
Fixes: 8183a7938cfec ("arm64: dts:
|
By
Lad Prabhakar
·
#5814
·
|
|
[PATCH 4.19.y-cip 0/2] Add sound support to R8A774E1 SoC
Hi All,
This patch series adds sound support to Renesas R8A774E1 SoC.
All the patches have been cherry picked from Linux v5.10-rc5.
Cheers,
Prabhakar
Lad Prabhakar (2):
arm64: dts: renesas:
Hi All,
This patch series adds sound support to Renesas R8A774E1 SoC.
All the patches have been cherry picked from Linux v5.10-rc5.
Cheers,
Prabhakar
Lad Prabhakar (2):
arm64: dts: renesas:
|
By
Lad Prabhakar
·
#5813
·
|