|
Re: [PATCH v3 4.19.y-cip 08/17] spi: spi-mem: export spi_mem_default_supports_op()
Has been done upstream by b5881b153bc8 ("spi: spi-mem: Make
spi_mem_default_supports_op() static inline")
I was once raising this concern internally that when commits are
backported not all of them
Has been done upstream by b5881b153bc8 ("spi: spi-mem: Make
spi_mem_default_supports_op() static inline")
I was once raising this concern internally that when commits are
backported not all of them
|
By
Sudip Mukherjee
·
#6042
·
|
|
Re: [PATCH v3 4.19.y-cip 12/17] spi: spi-mem: Compute length only when needed
Hi!
We can live with or without this one, I'd say.
You do not need to do anything at the moment: I believe we can simply
apply the series as-is.
Best regards,
Pavel
--
DENX Software
Hi!
We can live with or without this one, I'd say.
You do not need to do anything at the moment: I believe we can simply
apply the series as-is.
Best regards,
Pavel
--
DENX Software
|
By
Pavel Machek
·
#6041
·
|
|
Re: [PATCH v3 4.19.y-cip 16/17] spi: add Renesas RPC-IF driver
Hi Pavel,
Thank you for review.
Hi Pavel,
Thank you for review.
|
By
Lad Prabhakar
·
#6040
·
|
|
Re: [PATCH v3 4.19.y-cip 13/17] spi: spi-mem: Add a new API to support direct mapping
Hi Pavel,
Thank you for the review.
Hi Pavel,
Thank you for the review.
|
By
Lad Prabhakar
·
#6039
·
|
|
Re: [PATCH v3 4.19.y-cip 12/17] spi: spi-mem: Compute length only when needed
Hi Pavel,
Thank you for the review.
Hi Pavel,
Thank you for the review.
|
By
Lad Prabhakar
·
#6038
·
|
|
Re: [PATCH v3 4.19.y-cip 08/17] spi: spi-mem: export spi_mem_default_supports_op()
Hi Pavel,
Thank you for the review.
Hi Pavel,
Thank you for the review.
|
By
Lad Prabhakar
·
#6037
·
|
|
Re: [PATCH v3 4.19.y-cip 00/17] Add Renesas RPC-IF driver
Hi!
Thanks, series looks good. I commented on the individual patches, but
all but one are cleanup suggestions, not bugs spotted.
Tests do not show anything
Hi!
Thanks, series looks good. I commented on the individual patches, but
all but one are cleanup suggestions, not bugs spotted.
Tests do not show anything
|
By
Pavel Machek
·
#6036
·
|
|
Re: [PATCH v3 4.19.y-cip 16/17] spi: add Renesas RPC-IF driver
Hi!
#ifdefs here could be reduced...
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
Hi!
#ifdefs here could be reduced...
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
|
By
Pavel Machek
·
#6035
·
|
|
Re: [PATCH v3 4.19.y-cip 13/17] spi: spi-mem: Add a new API to support direct mapping
Hi!
This can be refactored to remove if/else nesting.
This can be
if (desc->nodirmap)
return spi_mem_no_dirmap_read(desc, offs, len, buf);
if (!(ctlr->mem_ops &&
Hi!
This can be refactored to remove if/else nesting.
This can be
if (desc->nodirmap)
return spi_mem_no_dirmap_read(desc, offs, len, buf);
if (!(ctlr->mem_ops &&
|
By
Pavel Machek
·
#6034
·
|
|
Re: [PATCH v3 4.19.y-cip 12/17] spi: spi-mem: Compute length only when needed
Hi!
If we are doing this kind of cleanups... I'd move "len" declaration
inside the if, too... Not that it matters much.
Best regards,
Pavel
Signed-off-by: Pavel Machek (CIP)
Hi!
If we are doing this kind of cleanups... I'd move "len" declaration
inside the if, too... Not that it matters much.
Best regards,
Pavel
Signed-off-by: Pavel Machek (CIP)
|
By
Pavel Machek
·
#6033
·
|
|
Re: [PATCH v3 4.19.y-cip 08/17] spi: spi-mem: export spi_mem_default_supports_op()
Hi!
This puts function definition directly into header file; I don't think
that will work when multiple files include it.
Adding "static inline" is the usual solution for this.
Best
Hi!
This puts function definition directly into header file; I don't think
that will work when multiple files include it.
Adding "static inline" is the usual solution for this.
Best
|
By
Pavel Machek
·
#6032
·
|
|
Re: [PATCH 4.19.y-cip 0/8] Optimize pinctrl and add QSPI[01] pins for RZ/G2{H,M,N,E}
Hi!
I went through this and "Add missing rpc-if clock on RZ/G2{E,M,N} SoC"
series, and they look okay to me. I can apply them if there are no
other comments.
Best regards,
Pavel
--
DENX
Hi!
I went through this and "Add missing rpc-if clock on RZ/G2{E,M,N} SoC"
series, and they look okay to me. I can apply them if there are no
other comments.
Best regards,
Pavel
--
DENX
|
By
Pavel Machek
·
#6031
·
|
|
[PATCH 4.19.y-cip 8/8] pinctrl: renesas: r8a77965: Add QSPI[01] pins, groups and functions
commit ffcd7f812dec2f1f27fe73b89c17a04ef6586325 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
commit ffcd7f812dec2f1f27fe73b89c17a04ef6586325 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
|
By
Lad Prabhakar
·
#6030
·
|
|
[PATCH 4.19.y-cip 7/8] pinctrl: renesas: r8a7796: Add QSPI[01] pins, groups and functions
commit 4356497e9eda8ec7dcd095b1ecd947ffe12917aa upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
commit 4356497e9eda8ec7dcd095b1ecd947ffe12917aa upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
|
By
Lad Prabhakar
·
#6029
·
|
|
[PATCH 4.19.y-cip 6/8] pinctrl: renesas: r8a77951: Add QSPI[01] pins, groups and functions
commit 590567bf6f6d989ba9d0fc406282d7a18cf5fa96 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
commit 590567bf6f6d989ba9d0fc406282d7a18cf5fa96 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
|
By
Lad Prabhakar
·
#6028
·
|
|
[PATCH 4.19.y-cip 5/8] pinctrl: renesas: r8a77990: Add QSPI[01] pins, groups and functions
commit 89ad953e1e727640e85beb82db3c71d45a59b177 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
commit 89ad953e1e727640e85beb82db3c71d45a59b177 upstream.
Add pins, groups and functions for QSPIO[01].
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
Reviewed-by: Biju Das
|
By
Lad Prabhakar
·
#6027
·
|
|
[PATCH 4.19.y-cip 4/8] pinctrl: renesas: r8a77990: Optimize pinctrl image size for R8A774C0
From: Biju Das <biju.das.jz@...>
commit 03522a59a9e7e5f464735e907891cd235aa68b1d upstream.
This driver supports both RZ/G2E and R-Car E3 SoCs.
Optimize pinctrl image size for RZ/G2E, when
From: Biju Das <biju.das.jz@...>
commit 03522a59a9e7e5f464735e907891cd235aa68b1d upstream.
This driver supports both RZ/G2E and R-Car E3 SoCs.
Optimize pinctrl image size for RZ/G2E, when
|
By
Lad Prabhakar
·
#6026
·
|
|
[PATCH 4.19.y-cip 3/8] pinctrl: renesas: r8a77965: Optimize pinctrl image size for R8A774B1
From: Biju Das <biju.das.jz@...>
commit 74c5fdc5b87a9435d6afbdd7d22c874c160bafc6 upstream.
This driver supports both RZ/G2N and R-Car M3-N SoCs.
Optimize pinctrl image size for RZ/G2N,
From: Biju Das <biju.das.jz@...>
commit 74c5fdc5b87a9435d6afbdd7d22c874c160bafc6 upstream.
This driver supports both RZ/G2N and R-Car M3-N SoCs.
Optimize pinctrl image size for RZ/G2N,
|
By
Lad Prabhakar
·
#6025
·
|
|
[PATCH 4.19.y-cip 2/8] pinctrl: renesas: r8a77951: Optimize pinctrl image size for R8A774E1
From: Biju Das <biju.das.jz@...>
commit b8029394efccf48687d9a7fae6c4747b81e35261 upstream.
This driver supports both RZ/G2H and R-Car H3 ES2 SoCs.
Optimize pinctrl image size for RZ/G2H,
From: Biju Das <biju.das.jz@...>
commit b8029394efccf48687d9a7fae6c4747b81e35261 upstream.
This driver supports both RZ/G2H and R-Car H3 ES2 SoCs.
Optimize pinctrl image size for RZ/G2H,
|
By
Lad Prabhakar
·
#6024
·
|
|
[PATCH 4.19.y-cip 1/8] pinctrl: renesas: r8a7796: Optimize pinctrl image size for R8A774A1
From: Biju Das <biju.das.jz@...>
commit 74ce7a8044b07268817828af2d6268801ddc012b upstream.
This driver supports both RZ/G2M and R-Car M3-W/W+ SoCs.
Optimize pinctrl image size for RZ/G2M,
From: Biju Das <biju.das.jz@...>
commit 74ce7a8044b07268817828af2d6268801ddc012b upstream.
This driver supports both RZ/G2M and R-Car M3-W/W+ SoCs.
Optimize pinctrl image size for RZ/G2M,
|
By
Lad Prabhakar
·
#6023
·
|