I've sent a patch that removes the superfluous semicolons, you were on CC. Just rebase on top and follow that new pattern. Thanks, Jan -- Siemens AG, Technology Competence Center Embedded Linux

you are right. I just checked my pipeline backlog and found that some months ago, I just checked for both without ; and not the case of both having it. Still we are changing the syntax already present

From: Jan Kiszka <jan.kiszka@...> Not needed. Signed-off-by: Jan Kiszka <jan.kiszka@...> --- .gitlab-ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Are you really sure about the closing semicolon? https://gitlab.com/jan-kiszka/ci-test/-/jobs/1951623081 https://gitlab.com/jan-kiszka/ci-test/-/blob/semicolon/.gitlab-ci.yml Jan -- Siemens AG,

sorry I'm not understanding what you want me to do. The closing semicolon is needed to the last-but-one command. Adding it to the last command break the script. --

Fine, as long as you do not need to adjust things in it afterwards. Granted, such cases will be less common. Jan -- Siemens AG, Technology Competence Center Embedded Linux

Why not just using the pre made image from https://storage.kernelci.org/images/rootfs/cip/ for reproducing errors ? Thanks, Alicef -- ====================================== Cybertrust Japan

KernelCI enviroment and gitlab-ci eviroment are mostly different. Changes on the symlink could possibly broke the KernelCI testing image or the gitlab-ci image. KernelCI working workflow is to have

Ok, we just need to keep an eye on target configs and options that deal with "testing" so that things are consistent and intuitive. So, the case that a test fails on kernel CI and someone want

Then, if the closing semicolon is needed, add it to the new line as well to avoid having to touch that when adding the next one. Jan -- Siemens AG, Technology Competence Center Embedded Linux

I'm just following the syntax that is already there. The gitlab-ci.yml file syntax preceding my commit is also doing same thing of adding that closing ; to the last-but-one command. You can check it

Currently it doesn't make too much sense to add such testing packages. CIP kernel image testing is done using ad-hoc images with a KernelCI built version of the testing packages for having a common

Hi! Yes, I was thinking about that, too. That would be easy way forward. Thank you and best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB

Thanks a lot for enabling this! One meta-question: How does this image relate to what happens to a standard image when adding kas/opt/test.yml? Does kas/opt/kernelci.yml:kas/opt/test.yml make sense?

Does gitlab-ci forces us to add that closing ; to the last-but-one command? If so, better add it to the new from the beginning. Jan -- Siemens AG, Technology Competence Center Embedded Linux

This is duplicating the default customization package, IIUC, for the purpose of adding further things. And you already miss some things due to this (WIRELESS_FIRMWARE_PACKAGE,

This is v2 of https://lists.cip-project.org/g/cip-dev/message/7264, right? Please flag that in the future. What is the delta? Jan -- Siemens AG, Technology Competence Center Embedded Linux

Hi Pavel, Just to add, I have tested audio playback/capture continuously for 3 days without anu issues. The race is between atomic context and quit function. Currently it is not triggering any

enable CIP core image KernelCI to be built with gitlab pipeline and uploaded to the KernelCI storage using KernelCI API. enable cip-core-image-kernelci to be built for amd64, arm and

The cip-core-image-kernelci need to be uploaded to the KernelCI production storage for been used by KernelCI. This script use the KernelCI API for uploading the cip-core-image-kernelci to the