|
Re: [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi Pavel,
By
Lad Prabhakar
·
#7229
·
|
|
Re: [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi!
And these are various minor nits I noticed while reviewing the code.
Best regards,
Pavel
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
Hi!
And these are various minor nits I noticed while reviewing the code.
Best regards,
Pavel
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
|
By
Pavel Machek
·
#7228
·
|
|
Re: [PATCH 5.10.y-cip 20/22] dmaengine: sh: make array ds_lut static
Hi!
Heh.
Array could be avoided altogether; you could check for power of two
and then count bits. That would give even shorter code, but I'm not
sure about readability.
I'd also not mind using
Hi!
Heh.
Array could be avoided altogether; you could check for power of two
and then count bits. That would give even shorter code, but I'm not
sure about readability.
I'd also not mind using
|
By
Pavel Machek
·
#7227
·
|
|
Re: [PATCH 5.10.y-cip 04/22] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver
Hi!
Should we check for overflows here, too?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
Hi!
Should we check for overflows here, too?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
|
By
Pavel Machek
·
#7226
·
|
|
Re: [PATCH 5.10.y-cip 03/22] dt-bindings: pinctrl: renesas: Add DT bindings for RZ/G2L pinctrl
Hi!
These are likely milliamps and millivolts, right? Elsewhere in device
trees microvolts and microamps are used, so that is not too
consistent.
Is the unit mentioned somewhere / should it
Hi!
These are likely milliamps and millivolts, right? Elsewhere in device
trees microvolts and microamps are used, so that is not too
consistent.
Is the unit mentioned somewhere / should it
|
By
Pavel Machek
·
#7225
·
|
|
Re: [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Thank you, applied.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Thank you, applied.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
|
By
Pavel Machek
·
#7224
·
|
|
Re: [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi all,
Hi!
I reviewed this series, there was no issue.
And build test was all green.
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/433945722
Reviewed-by: Nobuhiro Iwamatsu
Hi all,
Hi!
I reviewed this series, there was no issue.
And build test was all green.
https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/433945722
Reviewed-by: Nobuhiro Iwamatsu
|
By
Nobuhiro Iwamatsu
·
#7223
·
|
|
Re: 5.10.85 breaks CIP testing Re: [PATCH 5.10 00/33] 5.10.86-rc1 review
Hi,
Yes, we recommend using GCC with the rootfs environment.
And weare using the same container at compile time.
+1.
Also, I think that this will not be necessary by preparing a build container
that
Hi,
Yes, we recommend using GCC with the rootfs environment.
And weare using the same container at compile time.
+1.
Also, I think that this will not be necessary by preparing a build container
that
|
By
Nobuhiro Iwamatsu
·
#7222
·
|
|
Re: [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi!
Series looks okay to me. All I could find are
whitespaces/comments/documentation issues.
I'll proceed with testing; I can apply it if it passes and there are
no other comments.
Best
Hi!
Series looks okay to me. All I could find are
whitespaces/comments/documentation issues.
I'll proceed with testing; I can apply it if it passes and there are
no other comments.
Best
|
By
Pavel Machek
·
#7221
·
|
|
Re: 5.10.85 breaks CIP testing Re: [PATCH 5.10 00/33] 5.10.86-rc1 review
The natural pairing would be "buster/kernel 4.19/gcc-8" and
"bullseye/kernel 5.10/gcc-10", indeed.
I'm definitely not able to attend the TSC call tomorrow. If you want to
discuss this topic, someone
The natural pairing would be "buster/kernel 4.19/gcc-8" and
"bullseye/kernel 5.10/gcc-10", indeed.
I'm definitely not able to attend the TSC call tomorrow. If you want to
discuss this topic, someone
|
By
Jan Kiszka
·
#7220
·
|
|
[PATCH 5.10.y-cip 22/22] arm64: defconfig: Enable RZ_DMAC
From: Biju Das <biju.das.jz@...>
commit 7e2aa15f5ec3a8294127673f186c83b4d87cde13 upstream.
Enable DMAC driver support for Renesas RZ/G2L based platforms.
Signed-off-by: Biju Das
From: Biju Das <biju.das.jz@...>
commit 7e2aa15f5ec3a8294127673f186c83b4d87cde13 upstream.
Enable DMAC driver support for Renesas RZ/G2L based platforms.
Signed-off-by: Biju Das
|
By
Lad Prabhakar
·
#7219
·
|
|
[PATCH 5.10.y-cip 21/22] arm64: dts: renesas: r9a07g044: Add DMAC support
From: Biju Das <biju.das.jz@...>
commit bcd5e5173740087515bf3a05894917d0d8f5779f upstream.
Add DMAC support to RZ/G2L SoC DT.
Signed-off-by: Biju Das
From: Biju Das <biju.das.jz@...>
commit bcd5e5173740087515bf3a05894917d0d8f5779f upstream.
Add DMAC support to RZ/G2L SoC DT.
Signed-off-by: Biju Das
|
By
Lad Prabhakar
·
#7218
·
|
|
[PATCH 5.10.y-cip 20/22] dmaengine: sh: make array ds_lut static
From: Colin Ian King <colin.king@...>
commit 4c0eee50658746b0333d35a75d3db6e0aac08ef9 upstream.
Don't populate the read-only array ds_lut on the stack but instead it
static. Also makes the
From: Colin Ian King <colin.king@...>
commit 4c0eee50658746b0333d35a75d3db6e0aac08ef9 upstream.
Don't populate the read-only array ds_lut on the stack but instead it
static. Also makes the
|
By
Lad Prabhakar
·
#7217
·
|
|
[PATCH 5.10.y-cip 19/22] dmaengine: sh: rz-dmac: Add DMA clock handling
From: Biju Das <biju.das.jz@...>
commit 161596fd776a54df922158175ed844804a861c37 upstream.
Currently, DMA clocks are turned on by the bootloader.
This patch adds support for DMA clock
From: Biju Das <biju.das.jz@...>
commit 161596fd776a54df922158175ed844804a861c37 upstream.
Currently, DMA clocks are turned on by the bootloader.
This patch adds support for DMA clock
|
By
Lad Prabhakar
·
#7216
·
|
|
[PATCH 5.10.y-cip 18/22] dmaengine: sh: fix some NULL dereferences
From: Dan Carpenter <dan.carpenter@...>
commit 11a427be2c4749954e8b868ef5301dc65ca5a14b upstream.
The dma_free_coherent() function needs a valid device pointer or it will
crash.
Fixes:
From: Dan Carpenter <dan.carpenter@...>
commit 11a427be2c4749954e8b868ef5301dc65ca5a14b upstream.
The dma_free_coherent() function needs a valid device pointer or it will
crash.
Fixes:
|
By
Lad Prabhakar
·
#7215
·
|
|
[PATCH 5.10.y-cip 17/22] dmaengine: sh: Fix unused initialization of pointer lmdesc
From: Colin Ian King <colin.king@...>
commit 1e008336b9f590eb749ac96ccef4ea0301f79619 upstream.
Pointer lmdesc is being inintialized with a value that is never read,
it is later being
From: Colin Ian King <colin.king@...>
commit 1e008336b9f590eb749ac96ccef4ea0301f79619 upstream.
Pointer lmdesc is being inintialized with a value that is never read,
it is later being
|
By
Lad Prabhakar
·
#7214
·
|
|
[PATCH 5.10.y-cip 16/22] dmaengine: sh: Add DMAC driver for RZ/G2L SoC
From: Biju Das <biju.das.jz@...>
commit 5000d37042a61ca556fde2782ca40dbfa802ea16 upstream.
Add DMA Controller driver for RZ/G2L SoC.
Based on the work done by Chris Brandt for RZ/A DMA
From: Biju Das <biju.das.jz@...>
commit 5000d37042a61ca556fde2782ca40dbfa802ea16 upstream.
Add DMA Controller driver for RZ/G2L SoC.
Based on the work done by Chris Brandt for RZ/A DMA
|
By
Lad Prabhakar
·
#7213
·
|
|
[PATCH 5.10.y-cip 15/22] dmaengine: Extend the dma_slave_width for 128 bytes
From: Biju Das <biju.das.jz@...>
commit ab959c7d4ea086852f35c7ff20ecd79b7471cfad upstream.
Add DMA_SLAVE_BUSWIDTH_128_BYTES to dma_slave_width for DMA engines
and users to select 128
From: Biju Das <biju.das.jz@...>
commit ab959c7d4ea086852f35c7ff20ecd79b7471cfad upstream.
Add DMA_SLAVE_BUSWIDTH_128_BYTES to dma_slave_width for DMA engines
and users to select 128
|
By
Lad Prabhakar
·
#7212
·
|
|
[PATCH 5.10.y-cip 14/22] dt-bindings: dma: Document RZ/G2L bindings
From: Biju Das <biju.das.jz@...>
commit 9b9b12537d3a7b5bea6b9e8f20bffc2338724269 upstream.
Document RZ/G2L DMAC bindings.
Signed-off-by: Biju Das
From: Biju Das <biju.das.jz@...>
commit 9b9b12537d3a7b5bea6b9e8f20bffc2338724269 upstream.
Document RZ/G2L DMAC bindings.
Signed-off-by: Biju Das
|
By
Lad Prabhakar
·
#7211
·
|
|
[PATCH 5.10.y-cip 13/22] clk: renesas: r9a07g044: Add DMAC clocks/resets
From: Biju Das <biju.das.jz@...>
commit eb829e549ba65e48b1c16ddecb892a32b366d5e4 upstream.
Add DMAC clock and reset entries in CPG driver.
Signed-off-by: Biju Das
From: Biju Das <biju.das.jz@...>
commit eb829e549ba65e48b1c16ddecb892a32b366d5e4 upstream.
Add DMAC clock and reset entries in CPG driver.
Signed-off-by: Biju Das
|
By
Lad Prabhakar
·
#7210
·
|