Hi! This also changes PAGE_CACHE_SIZE -> PAGE_SIZE. I guess that's okay/bugfix, as PAGE_CACHE_SIZE probably is equal to PAGE_SIZE in all relevant configurations, but... Best regards, Pavel

Hi! Yep, I see, nasty; silent data corruption. Could this be merged to the patch that introduces the problem, or the original patch somehow modified that it will not corrupt data ... for example durin

Hi! (For the record, I'm now done with the review... with exception of renames&modifications in 66-69). It really depends on case by case basis -- on severity of the problem. I can take explanations,

Hi! I believe this is minor detail, and we can use the patches as-is. See my reply to Chris for thoughts about rest of the series. Best regards, Pavel

Hi! Actually, it seems that review on 1--33 is "minor updates are possible in mainline", so if you want (and there are no other comments from other maintainers), I can just take 1--33 and apply them t

Hi! There were more comments in my email, see below. But reading them again, I see I was wrong. Makefile magic was used to turn tmio_mmc_pio.c into tmio_mmc_core.o, so there's no bug here. Sorry for t

Hi! Did you see / do you want to comment on the hunks below? Original patch is marked by "> > >", my comments are marked by "> >" Best regards, Pavel

Hi! Is it -cip problem, or -stable problem? Best regards, Pavel

Hi! I have feeling that configurations in cip-kernel-config are a good start, but it is what we use for testing, and production needs may be slightly different. Best regards, Pavel

Hi! Thanks for heads-up! I see warning during configuration: HOSTLD scripts/kconfig/conf arch/arm/configs/moxa_mxc_defconfig:745:warning: symbol value 'm' invalid for RTC_DRV_DS1374_WDT # And this sug

Hi! This one seems to be reponsible. I have mailed author & lists... . commit df82285ab4b974f2040f31dbabdd11e055a282c2 Author: Mel Gorman <mgorman@...> Date: Tue Nov 5 21:16:27 2019 -0

Hi! v4.19.72-cip10-rt4 should be available at kernel.org. As of friday, upstream -rt tree did not move from v4.19.72. If it stays there for much longer, I'll need to figure out something. Trees are av

Hi! Oops, I was not paying close enough attention. Sorry about that. Thanks! Best regards, Pavel

Hi! If it is easy, please backport relevant changes. If it is not, it can stay this way. Best regards, Pavel

Hi! So... I see there were some follow up fixes done in the mainline. The series is also rather long to merge in one piece. Would it be possible to send new series, with the follow up fixes merged or

Hi! It is possible, but it would require me to rebase and then force push, causing problems for people who pulled the tree in the meantime. I believe risks outweight the advantages at this point. Best

Thanks! Macro is: It should be: [accessing variables not passed as macro arguments is strange/surprising]. Aha, sorry, I misparsed that one. Pavel

I'd understand turning 0 to 32 (that is if someone forgot to set it?). But turning 19 into 32 seems wrong. Best regards, Pavel

Hi! void rsnd_mod_name(char *buf, struct rsnd_mod *mod) {} would be usual way of doing it. Semantics would be similar to sprintf(). Best regards, Pavel

Hi! v4.19.85-rc (available at git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git ) contains at least 6 patches that look relevant to Renesas boards. They look ok to me, but you k