Hi! pm_runtime_get/put is unusually fine-grained here. Do we need error handling for pm_runtime_get? ... Missing mutex_unlock here. And here. Elsewhere you did pm_runtime_get inside the lock. (Which m

Hi! Indentation is not consistent here. Best regards, Pavel

Hi! Why is raw_spinlock used here? This is not really a core code... this makes analysis for rt safety more interesting. Best regards, Pavel

Hi! Ok, some cleanups are possible here. "32-bit". Lets get "." at the end of line consistent? Probably remove them. (Please fix globally). " " -> " ". Thanks and best regards, Pavel

Hi! I'll review this, but lets delay merging this after 6.1-cip1 is released. Best regards, Pavel

Hi! Thanks for review, I tested the series, added you reviewed-by tag (with added :) and pushed the changes. Best regards, Pavel

Hi! To be clear, by "forward-porting", I mean "making sure all patches specific to 5.10-cip are in 6.1-cip, too". Best regards, Pavel

Hi! I moved 6.1-cip branch a bit forward. Below is a summary of patches that needed forward-porting according to my scripts. Let me know if I missed some. These were too tangled for quick forward-port

Hi! This series looks okay to me, I can apply it if it passes testing and if there are no other comments. Best regards, Pavel

Hi! Should this be done in other cases when transmit is finished/stopped? Could this be refactored so that this code goes to sci_stop_tx()? This would be probably just a cleanup, so it should not prev

Hi! Thanks for review and testing. I applied the series. Best regards, Pavel

Hi! These look good to me: a | 998080b96 c77065 o+ | i2c: omap: Fix standard mode false ACK readings a | 911c66cfc 8ee3b0 .+ | drm/rockchip: Drop unbalanced obj unref a | 6378f4810 40882d o+ | NFSv4.1

Hi! Patches look ok to me. I can apply them if they pass testing and if there are no other comments. Best regards, Pavel

Hi! So we discussed options on todays meeting on IRC (you may want to review the log)... and if you are willing to do the work, we are willing to consider option 2. That does not mean we are willing t

Hi! They look good to me, too. Reviewed-by: Pavel Machek <pavel@...> Best regards, Pavel

Hi! Minor details I noticed during review (they should not prevent merge): KHz should be kHz. Double space (" "). Normally we'd put macro names in all uppercase. ... Is it possible that bit_clrl(priv-

Hi! This is the preferred option. Thanks and best regards, Pavel

Hi! I'll need to look at the commit more carefuly. However previous patch redefines pm_ptr macro, which may have implications elsewhere. And indeed commit 5ef11c56b2332613cacd5e7ac17cfb1a073b66ab r816

Hi! New realtime trees should be available at kernel.org. Trees are available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-cip-rt https://git.kernel.org/pub

Hi! Now applied. Best regards, Pavel