|
[PATCH 5.10.y-cip 15/21] can: rcar_canfd: Add support for RZ/G2L family
Hi! You are returning IRQ_HANDLED even when you do no handling. That probably will not do harm as long as interrupts are not shared. Is that guaranteed to be true? This leaks ndev; it should free_cand
Hi! You are returning IRQ_HANDLED even when you do no handling. That probably will not do harm as long as interrupts are not shared. Is that guaranteed to be true? This leaks ndev; it should free_cand
|
By
Pavel Machek
· #7258
·
|
|
[PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi! I'd preffer you to submit them. Thank you, Pavel
Hi! I'd preffer you to submit them. Thank you, Pavel
|
By
Pavel Machek
· #7230
·
|
|
[PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi! And these are various minor nits I noticed while reviewing the code. Best regards, Pavel diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetre
Hi! And these are various minor nits I noticed while reviewing the code. Best regards, Pavel diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetre
|
By
Pavel Machek
· #7228
·
|
|
[PATCH 5.10.y-cip 20/22] dmaengine: sh: make array ds_lut static
Hi! Heh. Array could be avoided altogether; you could check for power of two and then count bits. That would give even shorter code, but I'm not sure about readability. I'd also not mind using usual c
Hi! Heh. Array could be avoided altogether; you could check for power of two and then count bits. That would give even shorter code, but I'm not sure about readability. I'd also not mind using usual c
|
By
Pavel Machek
· #7227
·
|
|
[PATCH 5.10.y-cip 04/22] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver
Hi! Should we check for overflows here, too? Best regards, Pavel
Hi! Should we check for overflows here, too? Best regards, Pavel
|
By
Pavel Machek
· #7226
·
|
|
[PATCH 5.10.y-cip 03/22] dt-bindings: pinctrl: renesas: Add DT bindings for RZ/G2L pinctrl
Hi! These are likely milliamps and millivolts, right? Elsewhere in device trees microvolts and microamps are used, so that is not too consistent. Is the unit mentioned somewhere / should it be? Best r
Hi! These are likely milliamps and millivolts, right? Elsewhere in device trees microvolts and microamps are used, so that is not too consistent. Is the unit mentioned somewhere / should it be? Best r
|
By
Pavel Machek
· #7225
·
|
|
[PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Thank you, applied. Best regards, Pavel
Thank you, applied. Best regards, Pavel
|
By
Pavel Machek
· #7224
·
|
|
[PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic
Hi! Series looks okay to me. All I could find are whitespaces/comments/documentation issues. I'll proceed with testing; I can apply it if it passes and there are no other comments. Best regards, Pavel
Hi! Series looks okay to me. All I could find are whitespaces/comments/documentation issues. I'll proceed with testing; I can apply it if it passes and there are no other comments. Best regards, Pavel
|
By
Pavel Machek
· #7221
·
|
|
5.10.85 breaks CIP testing Re: [PATCH 5.10 00/33] 5.10.86-rc1 review
Hi! Thank you. We should do what our users are likely to do... they want stable kernel, and will not update toolchain in middle of product maintainance. [Updating toolchain when starting new product w
Hi! Thank you. We should do what our users are likely to do... they want stable kernel, and will not update toolchain in middle of product maintainance. [Updating toolchain when starting new product w
|
By
Pavel Machek
· #7196
·
|
|
[PATCH 5.10.y-cip 00/24] Add CPG and initial DTS/I for Renesas RZ/G2L SoC + SMARC EVK
Hi! Thank you. I checked the series and only found some details (some of them were fixed later in the series). I believe we can apply it. Reviewed-by: Pavel Machek <pavel@...> Pavel
Hi! Thank you. I checked the series and only found some details (some of them were fixed later in the series). I believe we can apply it. Reviewed-by: Pavel Machek <pavel@...> Pavel
|
By
Pavel Machek
· #7173
·
|
|
[PATCH 5.10.y-cip 23/24] clk: renesas: rzg2l: Add support to handle coupled clocks
Hi! So the clocks can have different properties (frequency?), but can only be enabled/disabled together? So we can't handle them as one clock? Best regards, Pavel
Hi! So the clocks can have different properties (frequency?), but can only be enabled/disabled together? So we can't handle them as one clock? Best regards, Pavel
|
By
Pavel Machek
· #7172
·
|
|
[PATCH 5.10.y-cip 11/24] arm64: dts: renesas: Add initial DTSI for RZ/G2{L,LC} SoC's
Hi! I just want to double check: Are the last two interrupts supposed to be same? Best regards, Pavel
Hi! I just want to double check: Are the last two interrupts supposed to be same? Best regards, Pavel
|
By
Pavel Machek
· #7171
·
|
|
[PATCH 5.10.y-cip 05/24] clk: renesas: Add CPG core wrapper for RZ/G2L SoC
Hi! Some comments below. ... I believe this wanted to return clk? But I'd recommend just directly returning the ERR_PTR(). ... Is " " missing? ... ... Should this be devm_kfree? (And is devm_kfree(NUL
Hi! Some comments below. ... I believe this wanted to return clk? But I'd recommend just directly returning the ERR_PTR(). ... Is " " missing? ... ... Should this be devm_kfree? (And is devm_kfree(NUL
|
By
Pavel Machek
· #7170
·
|
|
[PATCH 5.10.y-cip 0/7] Add binding and SoC identification for Renesas RZ/G2L SoC and Renesas RZ/G2L SMARC EVK
Hi! Looks good to me too. I have series ready due to testing, so I'll push it. Best regards, Pavel
Hi! Looks good to me too. I have series ready due to testing, so I'll push it. Best regards, Pavel
|
By
Pavel Machek
· #7118
·
|
|
New CVE entries in this week
Hi! This one is actually quite interesting. Untrusted users should not normally have shell access on embedded systems, but it highlights topic of coredumps. Default config of coredumping is unsuitable
Hi! This one is actually quite interesting. Untrusted users should not normally have shell access on embedded systems, but it highlights topic of coredumps. Default config of coredumping is unsuitable
|
By
Pavel Machek
· #7117
·
|
|
[PATCH 5.10.y-cip 0/7] Add binding and SoC identification for Renesas RZ/G2L SoC and Renesas RZ/G2L SMARC EVK
Hi! I have reviewed patches and they look okay to me. I'll proceed with testing. Do we have suitable board in the test lab / is there plan to add one? Best regards, Pavel
Hi! I have reviewed patches and they look okay to me. I'll proceed with testing. Do we have suitable board in the test lab / is there plan to add one? Best regards, Pavel
|
By
Pavel Machek
· #7108
·
|
|
[isar-cip-core][PATCH] linux-cip-rt: Add 5.10.83-cip1-rt1 recipe
Hi! I don't see anything obviously wrong. Thanks and best regards, Pavel
Hi! I don't see anything obviously wrong. Thanks and best regards, Pavel
|
By
Pavel Machek
· #7089
·
|
|
New CVE entries in this week
Hi! Hmm. Fun. 1e98ffea5a8935ec040ab72299e349cb44b8defd may have a clue: This leads to kernel pointer leaks if a match/target is set and then read back to userspace. So that sounds like KASLR workaroun
Hi! Hmm. Fun. 1e98ffea5a8935ec040ab72299e349cb44b8defd may have a clue: This leads to kernel pointer leaks if a match/target is set and then read back to userspace. So that sounds like KASLR workaroun
|
By
Pavel Machek
· #7079
·
|
|
[ANNOUNCE] 5.10.83-cip1-rt1 (-rt58)
Hi! There is first release of 5.10-cip-rt kernel available at kernel.org. Trees are available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip-rt https://gi
Hi! There is first release of 5.10-cip-rt kernel available at kernel.org. Trees are available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip-rt https://gi
|
By
Pavel Machek
· #7073
·
|
|
Realtime branch on 5.10 -- 5.10.83-cip1-rt0
Hi! -cip-rt branch is available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip-rt and it passes basic testing we do on gitlab. More testing would be welco
Hi! -cip-rt branch is available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip-rt and it passes basic testing we do on gitlab. More testing would be welco
|
By
Pavel Machek
· #7072
·
|