Hi! This needs to rpcif_disable_rpm() before returning, AFAICT. Same here. Best regards, Pavel

Hi! AFAICT this needs to be set to 0, not commented out. Best regards, Pavel

Hi! This confused me for a while. Some of hex numbers are 7 digits, some are 8. Making it consistent at 8 digits would be good. (Or maybe using 0x0 so it is clear we are not aiming for 8 digits). Best

Hi! Should pm_runtime_put() be called before returning failure to the caller? Best regards, Pavel

Hi! Along with refactoring code, this also removes locking from the reads. Which is okay AFAICT, but note in changelog would not hurt. Best regards, Pavel

Hi! Yes, sorry, I was looking at wrong tree. Best regards, Pavel

Hi! Wow. This must have been important. It looks like 5.10.95 (+4.4 and 4.19) was released just to get this fixed. Fix is "interesting" but... it should be fixed. Best regards, Pavel

Hi! Are they? I see fail label being unused in our 5.10 tree (but mainline uses it and I don't think we need it removed). But more importantly... staring at the code some more: err = register_candev(n

Hi! Looks good to me, go ahead :-). Best regards, Pavel

Hi! This one is queued up for 5.10.93. We likely don't need to do anything here. As it does not affect "our" kernels, we don't need to do anything. Good. This one looks relatively simple. Unfortunatle

Hi! It looks like stable 4.4.X maintainence ends real soon now: https://www.kernel.org/category/releases.html . I talked to Greg and it seems like plan is to end it at the beggining of month, rather t

Hi! New realtime trees should be available at kernel.org. Trees are available at https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-cip-rt https://git.kernel.org/pub/

Hi! So this needs more investigation and possibly 4.4 port? 08b64fc looks quite small/simple. ...and 4.19 and older is fixed, and 5.10 already contains f8d4f44df056c5b504b0d49683fb7279218fd207, so not

Hi! Thank you, applied. Best regards, Pavel

Hi! Thank you. The patches look good to me. You may want to include sha1 hash on the first line of changelog as [ Upstream commit c1833c3964d5bd8c163bd4e01736a38bc473cb8a ] ...as that's what's usually

Hi! Ok, this is really taking nice small steps. Thanks :-). You could help reviewers a bit more by saying "no functional changes" when there are none, but this was already very good job. I could not f

Hi! Ok, good. Patches passed testing (zynqmp board has problems but they are not kernel related) and I have pushed them. Best regards, Pavel

Hi! Thank you for answers. Is there reason not to submit it to stable? You are describing it is as a bugfix, and Greg takes those. [Advantages are a) community review, b) less patches to maintain for

Hi! Series looks okay to me. I did not test it but I assume it will pass. I can test/apply it quickly if history modification and force push is not required. I'd like confirmation from rest of the tea

Hi! > Is it possible to rearrange this patch before [1] and after [2]? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/?h=linux-5.10.y-cip&id=dcbef66029571fbada7522b2d