|
[PATCH 5.10.y-cip 00/61] Add Ethernet support to RZ/G2L
Hi! Thank you, applied. Best regards, Pavel
Hi! Thank you, applied. Best regards, Pavel
|
By
Pavel Machek
· #7450
·
|
|
[PATCH 4.19.y-cip 1/6] Backport netfilter: nf_tables: autoload modules from the abort path
Hi! Thank you. The patches look good to me. You may want to include sha1 hash on the first line of changelog as [ Upstream commit c1833c3964d5bd8c163bd4e01736a38bc473cb8a ] ...as that's what's usually
Hi! Thank you. The patches look good to me. You may want to include sha1 hash on the first line of changelog as [ Upstream commit c1833c3964d5bd8c163bd4e01736a38bc473cb8a ] ...as that's what's usually
|
By
Pavel Machek
· #7446
·
|
|
[PATCH 5.10.y-cip 00/61] Add Ethernet support to RZ/G2L
Hi! Ok, this is really taking nice small steps. Thanks :-). You could help reviewers a bit more by saying "no functional changes" when there are none, but this was already very good job. I could not f
Hi! Ok, this is really taking nice small steps. Thanks :-). You could help reviewers a bit more by saying "no functional changes" when there are none, but this was already very good job. I could not f
|
By
Pavel Machek
· #7444
·
|
|
Inserting patch into history was Re: [PATCH v2 5.10.y-cip 15/15] clk: renesas: r9a07g044: Mark IA55_CLK and DMAC_ACLK critical
Hi! Ok, good. Patches passed testing (zynqmp board has problems but they are not kernel related) and I have pushed them. Best regards, Pavel
Hi! Ok, good. Patches passed testing (zynqmp board has problems but they are not kernel related) and I have pushed them. Best regards, Pavel
|
By
Pavel Machek
· #7443
·
|
|
[PATCH 4.19.y-cip 1/6] Backport netfilter: nf_tables: autoload modules from the abort path
Hi! Thank you for answers. Is there reason not to submit it to stable? You are describing it is as a bugfix, and Greg takes those. [Advantages are a) community review, b) less patches to maintain for
Hi! Thank you for answers. Is there reason not to submit it to stable? You are describing it is as a bugfix, and Greg takes those. [Advantages are a) community review, b) less patches to maintain for
|
By
Pavel Machek
· #7442
·
|
|
[PATCH v2 5.10.y-cip 00/15] Add ADC/CANFD/IIC support for RZ/G2L
Hi! Series looks okay to me. I did not test it but I assume it will pass. I can test/apply it quickly if history modification and force push is not required. I'd like confirmation from rest of the tea
Hi! Series looks okay to me. I did not test it but I assume it will pass. I can test/apply it quickly if history modification and force push is not required. I'd like confirmation from rest of the tea
|
By
Pavel Machek
· #7438
·
|
|
Inserting patch into history was Re: [PATCH v2 5.10.y-cip 15/15] clk: renesas: r9a07g044: Mark IA55_CLK and DMAC_ACLK critical
Hi! > Is it possible to rearrange this patch before [1] and after [2]? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/?h=linux-5.10.y-cip&id=dcbef66029571fbada7522b2d
Hi! > Is it possible to rearrange this patch before [1] and after [2]? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/?h=linux-5.10.y-cip&id=dcbef66029571fbada7522b2d
|
By
Pavel Machek
· #7437
·
|
|
[PATCH 4.19.y-cip 1/6] Backport netfilter: nf_tables: autoload modules from the abort path
Hi! 0/6 email was not part of the thread, so I missed it in the first look. I see it fixes sysbot report. Do you have special loads where you are hitting these netfilter problems? Are similar fixes ne
Hi! 0/6 email was not part of the thread, so I missed it in the first look. I see it fixes sysbot report. Do you have special loads where you are hitting these netfilter problems? Are similar fixes ne
|
By
Pavel Machek
· #7436
·
|
|
[PATCH 4.19.y-cip 1/6] Backport netfilter: nf_tables: autoload modules from the abort path
Hi! Ok, let me take a look at the series. But... could you provide some kind of explanation of what these are and why you want them in -cip? These are not usual "hardware enablement" patches... Best r
Hi! Ok, let me take a look at the series. But... could you provide some kind of explanation of what these are and why you want them in -cip? These are not usual "hardware enablement" patches... Best r
|
By
Pavel Machek
· #7435
·
|
|
[PATCH 5.10.y-cip 00/31] Add sound/adc support for RZ/G2L
Hi! Yes, I was thinking about that, too. That would be easy way forward. Thank you and best regards, Pavel
Hi! Yes, I was thinking about that, too. That would be easy way forward. Thank you and best regards, Pavel
|
By
Pavel Machek
· #7336
·
|
|
[PATCH 5.10.y-cip 03/31] ASoC: sh: Add RZ/G2L SSIF-2 driver
Hi! Yes, but "struct snd_pcm_runtime *runtime = substream->runtime" above already accessed that data without locking. I believe your code will do fine in usual configurations. But reordering it should
Hi! Yes, but "struct snd_pcm_runtime *runtime = substream->runtime" above already accessed that data without locking. I believe your code will do fine in usual configurations. But reordering it should
|
By
Pavel Machek
· #7319
·
|
|
[PATCH 5.10.y-cip 03/31] ASoC: sh: Add RZ/G2L SSIF-2 driver
Hi! I'm not sure what the locking rules are here. Nit: I don't think !!() is useful here, as it is boolean expression anyway. But I notice that code is very careful to access strm->substream with spin
Hi! I'm not sure what the locking rules are here. Nit: I don't think !!() is useful here, as it is boolean expression anyway. But I notice that code is very careful to access strm->substream with spin
|
By
Pavel Machek
· #7314
·
|
|
[PATCH 5.10.y-cip 21/31] arm64: dts: renesas: rzg2l-smarc: Enable audio
Hi! "These commands are required for Playback/Capture". I'd expect spaces before {. (And yes, I'm picking nits here). Best regards, Pavel
Hi! "These commands are required for Playback/Capture". I'd expect spaces before {. (And yes, I'm picking nits here). Best regards, Pavel
|
By
Pavel Machek
· #7313
·
|
|
[PATCH 5.10.y-cip 10/31] iio: adc: Add driver for Renesas RZ/G2L A/D converter
Hi! ... This should be "DEFAULT". I'd write this as (reg & (RZG2L_ADM0_ADBSY | RZG2L_ADM0_ADCE)). Note that we wait, then check for timeout without using the register values. Which is strange and basi
Hi! ... This should be "DEFAULT". I'd write this as (reg & (RZG2L_ADM0_ADBSY | RZG2L_ADM0_ADCE)). Note that we wait, then check for timeout without using the register values. Which is strange and basi
|
By
Pavel Machek
· #7312
·
|
|
[PATCH 5.10.y-cip 04/31] ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel configuration parameter
Hi! I wish there was better solution to this. Device tree sources are quite human-readable, this really is not. Best regards, Pavel
Hi! I wish there was better solution to this. Device tree sources are quite human-readable, this really is not. Best regards, Pavel
|
By
Pavel Machek
· #7311
·
|
|
New CVE entries in this week
Hi! Interesting. That's wrong and unusual for stable tree. It was also merged in 4.19-stable as 0a3158ac5999fe. That's why we see 4.19 tree needing the fix. 4.4 is not affected. Good. Best regards, Pa
Hi! Interesting. That's wrong and unusual for stable tree. It was also merged in 4.19-stable as 0a3158ac5999fe. That's why we see 4.19 tree needing the fix. 4.4 is not affected. Good. Best regards, Pa
|
By
Pavel Machek
· #7310
·
|
|
4.4.296-rt229 is released
Hi! 4.4.296-rt229 is released. If we could get corresponding 4.4.296-cip release, it would make -cip-rt release easier. Thank you, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang
Hi! 4.4.296-rt229 is released. If we could get corresponding 4.4.296-cip release, it would make -cip-rt release easier. Thank you, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang
|
By
Pavel Machek
· #7276
·
|
|
[PATCH 5.10.y-cip 15/21] can: rcar_canfd: Add support for RZ/G2L family
Hi! I applied/pushed the series. Best regards, Pavel
Hi! I applied/pushed the series. Best regards, Pavel
|
By
Pavel Machek
· #7272
·
|
|
[PATCH 5.10.y-cip 15/21] can: rcar_canfd: Add support for RZ/G2L family
Hi! Yes. OTOH this is just a problem in error paths. Other patches look good, so this should probably be fixed in the mainline. I can apply the series if there are no other comments. Best regards, Pav
Hi! Yes. OTOH this is just a problem in error paths. Other patches look good, so this should probably be fixed in the mainline. I can apply the series if there are no other comments. Best regards, Pav
|
By
Pavel Machek
· #7263
·
|
|
New CVE entries in this week
Hi! This is Nokia modem stuff. It is enabled in several of our configs, but I don't think anyone is really using it. This may be worth looking into. Best regards, Pavel
Hi! This is Nokia modem stuff. It is enabled in several of our configs, but I don't think anyone is really using it. This may be worth looking into. Best regards, Pavel
|
By
Pavel Machek
· #7262
·
|