[isar-cip-core][PATCH 0/6] improve root home moving for layers


Henning Schild <henning.schild@...>
 

The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings from
that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i do not
care about them too much

Henning Schild (6):
customizations: make postinst idempotent
customizations: make postinst script report all potential errors
customizations: comment why we can not actually change home easily
change-root-homedir: split root home move into own package
kas: set clear text root password
CONTRIBUTING: fix note on patch prefixes

CONTRIBUTING.md | 2 +-
kas-cip.yml | 4 ++--
.../change-root-homedir.bb | 5 +++++
.../change-root-homedir/files/postinst | 21 +++++++++++++++++++
recipes-core/customizations/common.inc | 5 +++--
recipes-core/customizations/files/postinst | 10 ++++-----
6 files changed, 37 insertions(+), 10 deletions(-)
create mode 100644 recipes-core/change-root-homedir/change-root-homedir.bb
create mode 100644 recipes-core/change-root-homedir/files/postinst

--
2.37.4


Quirin Gylstorff
 

On 11/29/22 13:24, Henning Schild via lists.cip-project.org wrote:
The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings from
that other layer.
That is p1...p4
p5 and p6 are drive by findings, feel free to pick in any order i do not
care about them too much
Henning Schild (6):
customizations: make postinst idempotent
customizations: make postinst script report all potential errors
customizations: comment why we can not actually change home easily
change-root-homedir: split root home move into own package
kas: set clear text root password
CONTRIBUTING: fix note on patch prefixes
CONTRIBUTING.md | 2 +-
kas-cip.yml | 4 ++--
.../change-root-homedir.bb | 5 +++++
.../change-root-homedir/files/postinst | 21 +++++++++++++++++++
recipes-core/customizations/common.inc | 5 +++--
recipes-core/customizations/files/postinst | 10 ++++-----
6 files changed, 37 insertions(+), 10 deletions(-)
create mode 100644 recipes-core/change-root-homedir/change-root-homedir.bb
create mode 100644 recipes-core/change-root-homedir/files/postinst
Looks good to me. Tested with qemu-amd64.

Acked-by: Quirin Gylstorff <quirin.gylstorff@...>

Quirin


Jan Kiszka
 

On 21.12.22 14:01, Gylstorff Quirin wrote:


On 11/29/22 13:24, Henning Schild via lists.cip-project.org wrote:
The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings from
that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i do not
care about them too much

Henning Schild (6):
   customizations: make postinst idempotent
   customizations: make postinst script report all potential errors
   customizations: comment why we can not actually change home easily
   change-root-homedir: split root home move into own package
   kas: set clear text root password
   CONTRIBUTING: fix note on patch prefixes

  CONTRIBUTING.md                               |  2 +-
  kas-cip.yml                                   |  4 ++--
  .../change-root-homedir.bb                    |  5 +++++
  .../change-root-homedir/files/postinst        | 21 +++++++++++++++++++
  recipes-core/customizations/common.inc        |  5 +++--
  recipes-core/customizations/files/postinst    | 10 ++++-----
  6 files changed, 37 insertions(+), 10 deletions(-)
  create mode 100644
recipes-core/change-root-homedir/change-root-homedir.bb
  create mode 100644 recipes-core/change-root-homedir/files/postinst


Looks good to me. Tested with qemu-amd64.

Acked-by: Quirin Gylstorff <quirin.gylstorff@...>
Didn't hit the list and also patchwork. Please check for the reason and
resubmit.

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux


Jan Kiszka
 

On 02.01.23 18:04, Henning Schild wrote:
Am Mon, 2 Jan 2023 11:42:29 +0100
schrieb Jan Kiszka <jan.kiszka@...>:

On 21.12.22 14:01, Gylstorff Quirin wrote:


On 11/29/22 13:24, Henning Schild via lists.cip-project.org wrote:
The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings
from that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i
do not care about them too much

Henning Schild (6):
   customizations: make postinst idempotent
   customizations: make postinst script report all potential errors
   customizations: comment why we can not actually change home
easily change-root-homedir: split root home move into own package
   kas: set clear text root password
   CONTRIBUTING: fix note on patch prefixes

  CONTRIBUTING.md                               |  2 +-
  kas-cip.yml                                   |  4 ++--
  .../change-root-homedir.bb                    |  5 +++++
  .../change-root-homedir/files/postinst        | 21
+++++++++++++++++++ recipes-core/customizations/common.inc
|  5 +++-- recipes-core/customizations/files/postinst    | 10
++++----- 6 files changed, 37 insertions(+), 10 deletions(-)
  create mode 100644
recipes-core/change-root-homedir/change-root-homedir.bb
  create mode 100644
recipes-core/change-root-homedir/files/postinst


Looks good to me. Tested with qemu-amd64.

Acked-by: Quirin Gylstorff <quirin.gylstorff@...>
Didn't hit the list and also patchwork. Please check for the reason
and resubmit.
Ok i will try again but i wonder how Quirin could have it when he was
never on To or Cc. I would not really know what to check on my side,
will add Jan to Cc but not Quirin and we see who gets it which way.
Seems it did actually hit the list (that's where Quirin found it) but
not kernel.org (where I'm reading things):

https://lists.cip-project.org/g/cip-dev/topic/isar_cip_core_patch_0_6/95332873?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,95332873,previd%3D1672659862011165206,nextid%3D1671491382031296064&previd=1672659862011165206&nextid=1671491382031296064

vs.

https://lore.kernel.org/cip-dev/bee9645b-15e1-0f93-d0b5-df8974711459@siemens.com/T/#t

Sigh, this is annoying. Will open an issue with LF support again.

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux


Henning Schild <henning.schild@...>
 

Am Mon, 2 Jan 2023 11:42:29 +0100
schrieb Jan Kiszka <jan.kiszka@...>:

On 21.12.22 14:01, Gylstorff Quirin wrote:


On 11/29/22 13:24, Henning Schild via lists.cip-project.org wrote:
The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings
from that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i
do not care about them too much

Henning Schild (6):
   customizations: make postinst idempotent
   customizations: make postinst script report all potential errors
   customizations: comment why we can not actually change home
easily change-root-homedir: split root home move into own package
   kas: set clear text root password
   CONTRIBUTING: fix note on patch prefixes

  CONTRIBUTING.md                               |  2 +-
  kas-cip.yml                                   |  4 ++--
  .../change-root-homedir.bb                    |  5 +++++
  .../change-root-homedir/files/postinst        | 21
+++++++++++++++++++ recipes-core/customizations/common.inc
|  5 +++-- recipes-core/customizations/files/postinst    | 10
++++----- 6 files changed, 37 insertions(+), 10 deletions(-)
  create mode 100644
recipes-core/change-root-homedir/change-root-homedir.bb
  create mode 100644
recipes-core/change-root-homedir/files/postinst


Looks good to me. Tested with qemu-amd64.

Acked-by: Quirin Gylstorff <quirin.gylstorff@...>
Didn't hit the list and also patchwork. Please check for the reason
and resubmit.
Ok i will try again but i wonder how Quirin could have it when he was
never on To or Cc. I would not really know what to check on my side,
will add Jan to Cc but not Quirin and we see who gets it which way.

Henning

Jan


Henning Schild <henning.schild@...>
 

still v1:
- this was sent before but somehow did not make it, no change same v

The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings from
that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i do not
care about them too much

Henning Schild (6):
CONTRIBUTING: fix note on patch prefixes
customizations: make postinst idempotent
customizations: comment why we can not actually change home easily
kas: set clear text root password
customizations: make postinst script report all potential errors
change-root-homedir: split root home move into own package

CONTRIBUTING.md | 2 +-
kas-cip.yml | 4 ++--
.../change-root-homedir.bb | 5 +++++
.../change-root-homedir/files/postinst | 21 +++++++++++++++++++
recipes-core/customizations/common.inc | 5 +++--
recipes-core/customizations/files/postinst | 10 ++++-----
6 files changed, 37 insertions(+), 10 deletions(-)
create mode 100644 recipes-core/change-root-homedir/change-root-homedir.bb
create mode 100644 recipes-core/change-root-homedir/files/postinst

--
2.38.2


Jan Kiszka
 

On 02.01.23 18:08, Henning Schild wrote:
still v1:
- this was sent before but somehow did not make it, no change same v

The original idea was to make the rootfs home dir move and symlink
reusable in another layer, while also playing back some findings from
that other layer.

That is p1...p4

p5 and p6 are drive by findings, feel free to pick in any order i do not
care about them too much

Henning Schild (6):
CONTRIBUTING: fix note on patch prefixes
customizations: make postinst idempotent
customizations: comment why we can not actually change home easily
kas: set clear text root password
customizations: make postinst script report all potential errors
change-root-homedir: split root home move into own package

CONTRIBUTING.md | 2 +-
kas-cip.yml | 4 ++--
.../change-root-homedir.bb | 5 +++++
.../change-root-homedir/files/postinst | 21 +++++++++++++++++++
recipes-core/customizations/common.inc | 5 +++--
recipes-core/customizations/files/postinst | 10 ++++-----
6 files changed, 37 insertions(+), 10 deletions(-)
create mode 100644 recipes-core/change-root-homedir/change-root-homedir.bb
create mode 100644 recipes-core/change-root-homedir/files/postinst
Applied all except for the last one where I had style remarks.

Thanks,
Jan

--
Siemens AG, Technology
Competence Center Embedded Linux