[PATCH 5.10.y-cip 07/11] spi: rpc-if: Fix RPM imbalance in probe error path


Lad Prabhakar
 

From: Geert Uytterhoeven <geert+renesas@...>

commit 2f8cf5f642e80f8b6b0e660a9c86924a1f41cd80 upstream.

If rpcif_hw_init() fails, Runtime PM is left enabled.

Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
Signed-off-by: Geert Uytterhoeven <geert+renesas@...>
Reviewed-by: Wolfram Sang <wsa+renesas@...>
Link: https://lore.kernel.org/r/1c78a1f447d019bb66b6e7787f520ae78821e2ae.1648562287.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <broonie@...>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...>
---
drivers/spi/spi-rpc-if.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c
index 651d92028306..0f8096d7d7b0 100644
--- a/drivers/spi/spi-rpc-if.c
+++ b/drivers/spi/spi-rpc-if.c
@@ -158,14 +158,18 @@ static int rpcif_spi_probe(struct platform_device *pdev)

error = rpcif_hw_init(rpc, false);
if (error)
- return error;
+ goto out_disable_rpm;

error = spi_register_controller(ctlr);
if (error) {
dev_err(&pdev->dev, "spi_register_controller failed\n");
- rpcif_disable_rpm(rpc);
+ goto out_disable_rpm;
}

+ return 0;
+
+out_disable_rpm:
+ rpcif_disable_rpm(rpc);
return error;
}

--
2.17.1