[cip-dev] [PATCH 4.19.y 02/29] iommu/ipmmu-vmsa: Modify ipmmu_slave_whitelist() to check SoC revisions

Nobuhiro Iwamatsu nobuhiro1.iwamatsu at toshiba.co.jp
Tue May 7 02:11:47 UTC 2019


Hi,

On Fri, 3 May 2019 09:34:56 +0000
Fabrizio Castro <fabrizio.castro at bp.renesas.com> wrote:

> Hello Pavel,
> 
> Thank you for your feedback!
> 
> > From: Pavel Machek <pavel at denx.de>
> > Sent: 02 May 2019 22:28
> > Subject: Re: [cip-dev] [PATCH 4.19.y 02/29] iommu/ipmmu-vmsa:
> > Modify ipmmu_slave_whitelist() to check SoC revisions
> > 
> > Hi!
> >   
> > > commit b7ee92c6ff0e023a473b2500d771f6bf504fcc1a upstream.
> > >
> > > Some R-Car Gen3 SoCs has hardware restrictions on the IPMMU. So,
> > > to check whether this R-Car Gen3 SoC can use the IPMMU correctly,
> > > this patch modifies the ipmmu_slave_whitelist().
> > >
> > > Signed-off-by: Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh at renesas.com> Reviewed-by: Geert
> > > Uytterhoeven <geert+renesas at glider.be> Reviewed-by: Simon Horman
> > > <horms+renesas at verge.net.au> Signed-off-by: Joerg Roedel
> > > <jroedel at suse.de> Signed-off-by: Fabrizio Castro
> > > <fabrizio.castro at bp.renesas.com> ---
> > >  drivers/iommu/ipmmu-vmsa.c | 34
> > > ++++++++++++++++++++++++++-------- 1 file changed, 26
> > > insertions(+), 8 deletions(-) 
> >   
> > >  static int ipmmu_of_xlate(struct device *dev,
> > >  			  struct of_phandle_args *spec)
> > >  {
> > > -	/* For R-Car Gen3 use a white list to opt-in slave
> > > devices */
> > > -	if (soc_device_match(soc_rcar_gen3)
> > > && !ipmmu_slave_whitelist(dev))
> > > +	if (!ipmmu_slave_whitelist(dev))
> > >  		return -ENODEV;
> > >  
> > 
> > I just want to make sure "soc_device_match(soc_rcar_gen3) &&"
> > deletion is intentional here...  
> 
> It is. I wasn't sure about backporting patch
> 807596491d33d016e420d217cf1350aef2d2b3f7, but It didn't seem to add
> any value, what's your take on that?

As you wrote, there are no changes that have an impact.
But these these commits are like a set If I look at the content eatch commit.

Best regards,
  Nobuhiro




More information about the cip-dev mailing list