[cip-dev] [PATCH 4.4.y 05/52] pinctrl: sh-pfc: Add r8a77470 PFC support

Fabrizio Castro fabrizio.castro at bp.renesas.com
Tue May 14 09:23:53 UTC 2019


Hi Pavel,

Thank you for your feedback!

> From: Pavel Machek <pavel at denx.de>
> Sent: 13 May 2019 20:44
> Subject: Re: [cip-dev] [PATCH 4.4.y 05/52] pinctrl: sh-pfc: Add r8a77470 PFC support
> 
> Hi!
> 
> > From: Biju Das <biju.das at bp.renesas.com>
> >
> > commit 73dacc3403436fc246258c0933e35b6e809640ac upstream.
> >
> > Add PFC support for the R8A77470 SoC including pin groups for
> > some on-chip devices such as SCIF and MMC.
> >
> > Signed-off-by: Biju Das <biju.das at bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> > (fab: moved r8a77470_pinmux_info declaration from sh_pfc.h to core.h,
> > in pfc-r8a77470.c: added #include "core.h", removed #include "sh_pfc.h",
> > and added a few missing macro definitions)
> > Signed-off-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
> 
> > new file mode 100644
> > index 0000000..8973f61
> > --- /dev/null
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77470.c
> > @@ -0,0 +1,2368 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * R8A77470 processor support - PFC hardware block.
> > + *
> 
> SPDX here, good. But this one is GPL-2.0, and the other one was
> GPL-2.0+. Is that difference intentional?

What other SPDX header are you referring to?

Thanks,
Fab

> 								Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


More information about the cip-dev mailing list